#2559. Update non-redirecting generative constructors tests #3012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Dec 11, 2024
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good! Just one thing might follow a different rule than the one that seems to be assumed.
LanguageFeatures/Augmentation-libraries/augmenting_constructors_A09_t04.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for niticing. Fixed. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 13, 2024
2024-12-12 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for reserved word `augmented` in constructors. Part 1. (dart-lang/co19#3014) 2024-12-12 sgrekhov22@gmail.com dart-lang/co19#2559. Update assertions for redirecting generative constructors tests (dart-lang/co19#3013) 2024-12-11 sgrekhov22@gmail.com dart-lang/co19#2559. Update non-redirecting generative constructors tests (dart-lang/co19#3012) 2024-12-11 sgrekhov22@gmail.com dart-lang/co19#2559. Add factory constructors to augmented_expression_A04_t*.dart tests (dart-lang/co19#3011) 2024-12-09 sgrekhov22@gmail.com dart-lang/co19#2559. Update assertion text for for some of augmented expressions tests (dart-lang/co19#3010) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I1d95b2092a91651bebb63c82c11cf154ff5da863 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400580 Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.