Skip to content

#2559. Add metadata tests. Part 1. #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 17, 2024
Merged

#2559. Add metadata tests. Part 1. #3017

merged 4 commits into from
Dec 17, 2024

Conversation

@sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Dec 16, 2024

No description provided.

@sgrekhov sgrekhov marked this pull request as draft December 16, 2024 14:51
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Dec 16, 2024

Sorry, not ready for review yet

@sgrekhov sgrekhov marked this pull request as ready for review December 17, 2024 07:59
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Dec 17, 2024

Ready for review now.

eernstg
eernstg reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm suggesting that one extra case is covered (@augmented() is OK on an augmenting declaration as long as it isn't inside that declaration). This gives rise to a somewhat large number of changes, but they are very systematic.

sgrekhov
sgrekhov commented Dec 17, 2024
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated. PTAL.

@sgrekhov sgrekhov requested a review from eernstg December 17, 2024 14:02
eernstg
eernstg approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit d23755b into dart-lang:master Dec 17, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 20, 2024
@sgrekhov
[co19] Roll co19 to 6d2a3c5c20b77475cae2c6c70ff62b1d2c55672e
4a52cbc 
2024-12-19 sgrekhov22@gmail.com dart-lang/co19#2976. Add equality tests. Part 1. (dart-lang/co19#3021)
2024-12-19 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests for class-like declarations (dart-lang/co19#3019)
2024-12-18 sgrekhov22@gmail.com Fix Finalizer_A01_t04.dart test (dart-lang/co19#3020)
2024-12-18 sgrekhov22@gmail.com dart-lang/co19#2559. Fix metadata tests (dart-lang/co19#3018)
2024-12-17 sgrekhov22@gmail.com dart-lang/co19#2559. Add metadata tests. Part 1. (dart-lang/co19#3017)
2024-12-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#3016)
2024-12-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for reserved word `augmented` in constructors. Part 2. (dart-lang/co19#3015)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Idf2d4813fdca6d4107ee17d508cf5f8b27b1b4ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401882
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgrekhov @eernstg