#2976. Add non-ambiguity tests #3034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jan 9, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, with a few comments!
I'm worried about tests with multiple syntax errors, but I think we can avoid splitting it into 117 tests and still be rather safe.
LanguageFeatures/Static-access-shorthand/non_ambiguity_A01_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t04.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
Jan 10, 2025
LanguageFeatures/Static-access-shorthand/non_ambiguity_A01_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t04.dart
Outdated
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 17, 2025
2025-01-17 sgrekhov22@gmail.com Fixes dart-lang/co19#3044. Update expected errors positions for CFE (dart-lang/co19#3046) 2025-01-15 sgrekhov22@gmail.com dart-lang/co19#2976. Add more tests for records, factories and parenthesized expressions (dart-lang/co19#3047) 2025-01-15 sgrekhov22@gmail.com dart-lang/co19#2119. Actualize nnbd/static_errors_A12* description (dart-lang/co19#3048) 2025-01-14 sgrekhov22@gmail.com Fixes dart-lang/co19#3029. Add more tests for constants (dart-lang/co19#3045) 2025-01-14 sgrekhov22@gmail.com dart-lang/co19#2976. Add patterns tests (dart-lang/co19#3031) 2025-01-13 sgrekhov22@gmail.com dart-lang/co19#2976. Add more operators tests (dart-lang/co19#3043) 2025-01-13 sgrekhov22@gmail.com dart-lang/co19#3030. Add tests constants tests for String.length (dart-lang/co19#3041) 2025-01-13 sgrekhov22@gmail.com Fixes dart-lang/co19#3038. Read link to finalized object to avoid early finalization (dart-lang/co19#3042) 2025-01-10 sgrekhov22@gmail.com dart-lang/co19#2976. Add non-ambiguity tests (dart-lang/co19#3034) 2025-01-10 sgrekhov22@gmail.com dart-lang/co19#2976. Add more grammar tests (dart-lang/co19#3035) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I9feb50a33b33e85dc017d0d47829502d4f631ac7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405001 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on dart-lang/language#4218 (comment)