Skip to content

#2976. Add more grammar tests #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

#2976. Add more grammar tests #3035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0950612
#2976. Add more grammar tests
sgrekhov Jan 6, 2025
52a703d
Implement review recommendations
sgrekhov Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
145 changes: 145 additions & 0 deletions LanguageFeatures/Static-access-shorthand/grammar_A05_t01.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion We introduce grammar productions of the form:
/// ```
/// <postfixExpression> ::= ... -- all current productions
/// | <staticMemberShorthand> -- added production
///
/// <constantPattern> ::= ... -- all current productions
/// | <staticMemberShorthandValue> -- No selectors, no `.new`.
///
/// <staticMemberShorthand> ::= <staticMemberShorthandHead> <selector>*
///
/// <staticMemberShorthandHead> ::=
/// <staticMemberShorthandValue>
/// | '.' 'new' -- shorthand unnamed constructor
///
/// <staticMemberShorthandValue> ::= -- something that can potentially create a value.
/// | '.' <identifier> -- shorthand for qualified name
/// | 'const' '.' (<identifier> | 'new') <arguments> -- shorthand for constant object creation
/// ```
///
/// @description Checks that it is a compile-time error to use the static access
/// shorthand syntax with the prefix `!` operator.
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=enum-shorthands

class C {
static bool get getterTrue => true;
static bool methodTrue() => true;
static List<bool> values = [true];
}

mixin M on C {
static bool get getterTrue => true;
static bool methodTrue() => true;
static List<bool> values = [true];
}
class MC = C with M;

enum E {
e1;

static bool get getterTrue => true;
static bool methodTrue() => true;
static List<bool> boolValues = [true];
}

extension type ET(int v) implements int {
static bool get getterTrue => true;
static bool methodTrue() => true;
static List<bool> values = [true];
}

main() {
Object o = C();
if (o is C) {
o = !.getterTrue;
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = C();
if (o is C) { // ignore: unnecessary_type_check
o = !.methodTrue();
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = C();
if (o is C) { // ignore: unnecessary_type_check
o = !.values[0];
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

o = MC();
if (o is M) {
o = !.getterTrue;
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = MC();
if (o is M) { // ignore: unnecessary_type_check
o = !.methodTrue();
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = MC();
if (o is M) { // ignore: unnecessary_type_check
o = !.values[0];
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

o = E.e1;
if (o is E) {
o = !.getterTrue;
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = E.e1;
if (o is E) { // ignore: unnecessary_type_check
o = !.methodTrue();
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = E.e1;
if (o is E) { // ignore: unnecessary_type_check
o = !.boolValues[0];
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

o = ET(0);
if (o is ET) {
o = !.getterTrue;
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = ET(0);
if (o is ET) { // ignore: unnecessary_type_check
o = !.methodTrue();
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = ET(0);
if (o is ET) { // ignore: unnecessary_type_check
o = !.values[0];
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
}
145 changes: 145 additions & 0 deletions LanguageFeatures/Static-access-shorthand/grammar_A05_t02.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion We introduce grammar productions of the form:
/// ```
/// <postfixExpression> ::= ... -- all current productions
/// | <staticMemberShorthand> -- added production
///
/// <constantPattern> ::= ... -- all current productions
/// | <staticMemberShorthandValue> -- No selectors, no `.new`.
///
/// <staticMemberShorthand> ::= <staticMemberShorthandHead> <selector>*
///
/// <staticMemberShorthandHead> ::=
/// <staticMemberShorthandValue>
/// | '.' 'new' -- shorthand unnamed constructor
///
/// <staticMemberShorthandValue> ::= -- something that can potentially create a value.
/// | '.' <identifier> -- shorthand for qualified name
/// | 'const' '.' (<identifier> | 'new') <arguments> -- shorthand for constant object creation
/// ```
///
/// @description Checks that it is a compile-time error to use the static access
/// shorthand syntax with the unary `-` operator.
/// @author sgrekhov22@gmail.com

// SharedOptions=--enable-experiment=enum-shorthands

class C {
static int get one => 1;
static int two() => 2;
static List<int> values = [1];
}

mixin M on C {
static int get one => 1;
static int two() => 2;
static List<int> values = [1];
}
class MC = C with M;

enum E {
e1;

static int get one => 1;
static int two() => 2;
static List<int> intValues = [1];
}

extension type ET(int v) implements int {
static int get one => 1;
static int two() => 2;
static List<int> values = [1];
}

main() {
Object o = C();
if (o is C) {
o = -.one;
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = C();
if (o is C) { // ignore: unnecessary_type_check
o = -.two();
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = C();
if (o is C) { // ignore: unnecessary_type_check
o = -.values[0];
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

o = MC();
if (o is M) {
o = -.one;
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = MC();
if (o is M) { // ignore: unnecessary_type_check
o = -.two();
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = MC();
if (o is M) { // ignore: unnecessary_type_check
o = -.values[0];
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

o = E.e1;
if (o is E) {
o = -.one;
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = E.e1;
if (o is E) { // ignore: unnecessary_type_check
o = -.two();
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = E.e1;
if (o is E) { // ignore: unnecessary_type_check
o = -.intValues[0];
// ^
// [analyzer] unspecified
// [cfe] unspecified
}

o = ET(0);
if (o is ET) {
o = -.one;
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = ET(0);
if (o is ET) { // ignore: unnecessary_type_check
o = -.two();
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
o = ET(0);
if (o is ET) { // ignore: unnecessary_type_check
o = -.values[0];
// ^
// [analyzer] unspecified
// [cfe] unspecified
}
}
Loading
Loading