Skip to content

Fixes #3038. Read link to finalized object to avoid early finalization #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fixes #3038. Read link to finalized object to avoid early finalization #3042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t04.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
/// and will run in that zone when called.
///
/// @description Checks that finalizer object can be created and its callback
/// will never run if attached object is accessible.
/// will never run if attached object is accessed.
/// @author iarkh@unipro.ru

import 'dart:async';
import '../../gc_utils_lib.dart';
import '../../../../Utils/expect.dart';

int called = 0;
Object? accessibleLink;
Object? accessedLink;

final Finalizer finalizer = Finalizer((token) {
Expect.equals(123, token);
Expand All @@ -32,20 +32,23 @@ attachToFinalizer() async {
Object? object = Object();
finalizer.attach(object, 123);
await triggerGcWithDelay();
accessibleLink = object;
accessedLink = object;
object = null;
Expect.equals(0, called);
() async {
await triggerGcWithDelay();
Expect.equals(0, called);
// If accessedLink is never read the optimizer may kill the object after
// `object = null`. Read it here to avoid it.
print(accessedLink);
completer.complete();
}();
}

main() async {
await attachToFinalizer();
await completer.future;
accessibleLink = null;
accessedLink = null;
// Previous triggerGc move some objects to old space. Do multiple GCs to
// force all objects to old space.
await triggerGcWithDelay(repeat: 3);
Expand Down
Loading