#3054. Add covariant parameters tests #3059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jan 29, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good!
I commented on a couple of tests because I think they could be stronger if they would use an actual type argument for X which is different from a top type: This means that we can see a failure if there is a bug where the type of a formal parameter is relaxed to Object?, but it was already Object? because that was the value of X.
On the other hand, this is of course a corner case, too, so maybe it's fine to have a test where X is bound to Object?.
However, it's more important to ensure that the relaxation of the formal parameter type to Object? does take place than it is to check that nothing wrong happens when that relaxation is a no-op (unless this is already covered by some other test).
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A03_t02.dart
Outdated
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A03_t02.dart
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A03_t03.dart
Outdated
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A03_t03.dart
Outdated
Show resolved
Hide resolved
...Extraction/Instance_Method_Closurization/method_closurization_positional_params_A03_t02.dart
Show resolved
Hide resolved
sgrekhov
commented
Jan 29, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Thanx! Updated. PTAL
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A03_t02.dart
Outdated
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A03_t02.dart
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A03_t03.dart
Outdated
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A03_t03.dart
Outdated
Show resolved
Hide resolved
...Extraction/Instance_Method_Closurization/method_closurization_positional_params_A03_t02.dart
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 31, 2025
2025-01-29 sgrekhov22@gmail.com dart-lang/co19#3054. Add covariant parameters tests (dart-lang/co19#3059) 2025-01-29 sgrekhov22@gmail.com dart-lang/co19#3054. Existing tests renamed to Instance Method Closurization (dart-lang/co19#3058) 2025-01-27 sgrekhov22@gmail.com dart-lang/co19#2162. Add static member and non-redirecting factory constructor conflict test (dart-lang/co19#3056) 2025-01-27 sgrekhov22@gmail.com dart-lang/co19#2145. Update existing "Evaluation of Implicit Variable Getters" tests (dart-lang/co19#3052) 2025-01-24 sgrekhov22@gmail.com dart-lang/co19#2138. Add more tests for `call` method/getter (dart-lang/co19#3053) 2025-01-24 sgrekhov22@gmail.com dart-lang/co19#2162. Add more constructor vs. static member conflict tests (dart-lang/co19#3055) 2025-01-17 sgrekhov22@gmail.com dart-lang/co19#2976. Add more tests for nullable and FutureOr types (dart-lang/co19#3050) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ibeafe23be5d8b913db4e83b23f3820cafc3802ac Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406940 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Feb 4, 2025
Add covariant parameters tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR is Ok I'll add the same tests for mixins, extension types etc in the next one.