#3057. Add more flow analysis tests for type Never. Part 2. #3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Feb 17, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good! Commented on a few typos.
I also commented on a couple of cases where I'm surprised that the flow analysis would be able to reach a particular conclusion. If it does work, and the spec actually says it should, then that's fine. If it doesn't work, and the spec agrees, then the expectation should be adjusted.
Otherwise we may need to revisit the spec.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 24, 2025
2025-02-20 sgrekhov22@gmail.com Fixes dart-lang/co19#3084. Update expected errors positions in member_definition_t10.dart (dart-lang/co19#3085) 2025-02-19 sgrekhov22@gmail.com dart-lang/co19#3057. Add tests for logical and, or and null-check operators (dart-lang/co19#3082) 2025-02-19 sgrekhov22@gmail.com dart-lang/co19#3057. Add more null-check tests (dart-lang/co19#3081) 2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057. Update operator `==` tests updated and add new ones (dart-lang/co19#3077) 2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057. Add instance check tests (dart-lang/co19#3078) 2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057. Add flow analysis tests for throw expression (dart-lang/co19#3076) 2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057. Add more flow analysis tests for type Never. Part 2. (dart-lang/co19#3071) 2025-02-17 sgrekhov22@gmail.com Fixes dart-lang/co19#3079. Fix numerous typos in Parts with imports tests (dart-lang/co19#3080) 2025-02-17 sgrekhov22@gmail.com dart-lang/co19#3057. Add more flow analysis tests for type Never (dart-lang/co19#3070) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I3d4450e3687fe542737b397aa097d56211534c9b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411240 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.