Skip to content

Conversation

@sgrekhov
Copy link
Contributor

@eernstg
Copy link
Member

eernstg commented Feb 13, 2025

Oh, @sgrekhov, it would be considerably easier to review two PRs: One renaming PR and one "fixing" PR. Could you create the renaming PR and rebase this one when the renaming PR has been landed? (That would presumably turn this one into that small fixing PR automatically).

@sgrekhov
Copy link
Contributor Author

Oh, @sgrekhov, it would be considerably easier to review two PRs: One renaming PR and one "fixing" PR. Could you create the renaming PR and rebase this one when the renaming PR has been landed? (That would presumably turn this one into that small fixing PR automatically).

Of course! Will do!

@sgrekhov sgrekhov changed the title #3057. Operator == tests renamed and fixed #3057. Operator == tests renamed Feb 13, 2025
@sgrekhov
Copy link
Contributor Author

Updated. Now this PR contains renaming only. Please review.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@eernstg eernstg merged commit 362f338 into dart-lang:master Feb 13, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 14, 2025
2025-02-13 sgrekhov22@gmail.com dart-lang/co19#3057. Operator `==` tests renamed (dart-lang/co19#3075)
2025-02-13 sgrekhov22@gmail.com Fixes dart-lang/co19#3073. Add `asyncEnd()` after `cleanup` invocation in `asyncTest` (dart-lang/co19#3074)
2025-02-07 sgrekhov22@gmail.com dart-lang/co19#3054. Add more test cases to closurization tests. Part 2. (dart-lang/co19#3069)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ic56a06a8f8ec1fc36b04b5250ad5a4cf698e5404
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409940
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants