Fixes #3143. Update assertions, add language version, add new tests #3144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Apr 15, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good! I think it would be helpful to deal with language versions more explicitly, though.
sgrekhov
commented
Apr 15, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Thank you. Updated. PTAL
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 22, 2025
2025-04-16 sgrekhov22@gmail.com dart-lang/co19#3057. Add more try-catch(-finally) tests (dart-lang/co19#3149) 2025-04-16 sgrekhov22@gmail.com dart-lang/co19#3057. Add more flow analysis tests for try-catch and try-finally (dart-lang/co19#3142) 2025-04-15 sgrekhov22@gmail.com Fixes dart-lang/co19#3143. Update assertions, add language version, add new tests (dart-lang/co19#3144) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Id1491e304f02d580a42d1c3d9831b96eaca52fc6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423280 Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.