#3057. Add more reachability tests for switch
#3173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
May 12, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, couple of comments!
TypeSystem/flow-analysis/reachability_switch_expression_A06_t01.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A06_t02.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
May 12, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Updated. PTAL. One test left unchanged because I belive it is ok.
TypeSystem/flow-analysis/reachability_switch_expression_A06_t01.dart
Outdated
Show resolved
Hide resolved
TypeSystem/flow-analysis/reachability_switch_expression_A06_t02.dart
Outdated
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 16, 2025
2025-05-15 sgrekhov22@gmail.com dart-lang/co19#3057. Add more promotion tests for extension types (dart-lang/co19#3184) 2025-05-14 sgrekhov22@gmail.com dart-lang/co19#3057. Add some promotion tests for extension types (dart-lang/co19#3183) 2025-05-14 sgrekhov22@gmail.com Fixes dart-lang/co19#3177. Ignore static warnings in non_ambiguity_A02_t01.dart (dart-lang/co19#3181) 2025-05-13 sgrekhov22@gmail.com dart-lang/co19#3057. Add promotion via assignment tests. Check top types. (dart-lang/co19#3167) 2025-05-13 sgrekhov22@gmail.com Fixes dart-lang/co19#3177. Fix typos, add issue number (dart-lang/co19#3178) 2025-05-12 sgrekhov22@gmail.com dart-lang/co19#3057. Add more reachability tests for `switch` (dart-lang/co19#3173) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Id5da975045bc2205ca470c5e429b37bcb822f18b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428960 Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.