#3180. Add JSExport tests. Part 1. #3250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jul 7, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good. I think a couple of extra things could be covered (perhaps that's already planned for Part 2 and on?):
- Invoking
createJSInteropWrapperwith a type argument that differs from the run time type of the actual argument (presumably, this would just work, it's OK that the Dart object is a proper subtype of the required type). Also, it's a compile time error (already in the CFE, presumably) if the actual type argument isn't a supertype of the type of the actual argument. - Using
@JSExporton one or more members (in a class that has@JSExportitself, and in a class that doesn't have it).
Contributor
Author
It'll be part of tests for
It'll be in the Part 2. |
eernstg
approved these changes
Jul 7, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Thanks! Awaiting further comments.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 11, 2025
2025-07-10 sgrekhov22@gmail.com dart-lang/co19#3180. Add JSExport tests. Part 3. (dart-lang/co19#3252) 2025-07-09 sgrekhov22@gmail.com dart-lang/co19#3180. Add JSExport tests. Part 2. (dart-lang/co19#3251) 2025-07-08 sgrekhov22@gmail.com dart-lang/co19#3180. Add additional `NullRejectionException` test (dart-lang/co19#3249) 2025-07-08 sgrekhov22@gmail.com dart-lang/co19#3180. Add JSExport tests. Part 1. (dart-lang/co19#3250) 2025-07-04 sgrekhov22@gmail.com Fixes dart-lang/co19#3245. Fix int to double conversion in jsNumber_t01.dart (dart-lang/co19#3248) 2025-07-04 sgrekhov22@gmail.com dart-lang/co19#3180. Add `NullRejectionException` tests (dart-lang/co19#3247) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: I4b44a79d210d19153a464a9eadb86996d2876cf6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/439840 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.