Skip to content

Conversation

@sgrekhov
Copy link
Contributor

All tests from this PR now passing on CFE

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit d07b563 into dart-lang:master Jul 29, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 4, 2025
2025-08-01 sgrekhov22@gmail.com dart-lang/co19#3180. Add `@JS()` annotation tests. Part 3. (dart-lang/co19#3269)
2025-08-01 sgrekhov22@gmail.com dart-lang/co19#3180. Add `@JS()` annotation tests. Part 2. (dart-lang/co19#3268)
2025-07-31 sgrekhov22@gmail.com dart-lang/co19#3180. Add `typeofEquals` tests (dart-lang/co19#3262)
2025-07-31 sgrekhov22@gmail.com dart-lang/co19#3180. Add more instanceOfString tests (dart-lang/co19#3264)
2025-07-29 sgrekhov22@gmail.com Fixes dart-lang/co19#3261. Update expected errors positions for CFE (dart-lang/co19#3267)
2025-07-28 sgrekhov22@gmail.com dart-lang/co19#3180. Update assertion for staticInterop tests (dart-lang/co19#3265)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I5167edcc66a25f6e626cb4d8c1f5d2b5ec4ad82a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/443280
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants