#3180. Add importModule() tests #3282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Aug 19, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
LGTM, awaiting further input.
srujzs
approved these changes
Aug 19, 2025
sgrekhov
commented
Aug 20, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Thank you. Updated. PTAL.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 22, 2025
2025-08-22 sgrekhov22@gmail.com Fixes dart-lang/co19#3286. Fix typo in interop_type_A03_t01.dart (dart-lang/co19#3287) 2025-08-21 sgrekhov22@gmail.com dart-lang/co19#3180. Add test for tear-off members of JS interop type (dart-lang/co19#3284) 2025-08-20 sgrekhov22@gmail.com dart-lang/co19#3180. Add importModule() tests (dart-lang/co19#3282) 2025-08-18 sgrekhov22@gmail.com dart-lang/co19#3180. Add interop types tests. Part 2. (dart-lang/co19#3280) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: Iff5899187a184c5bcb0c3372f605057b99f4d14e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/446382 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.