Skip to content

Conversation

@devoncarew
Copy link
Contributor

A follow-up to #3016 - make the converted web frontend script better follow Dart conventions.

@devoncarew devoncarew requested a review from srawlins April 11, 2022 22:50
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@devoncarew
Copy link
Contributor Author

As a note to myself, I would like a 'land-on-green' label for the dart repos (the label would be auto-removed if the PR didn't have a valid review; would auto-land the PR once all the bots went green).

@parlough
Copy link
Member

Seems like there is a feature like that which can be enabled for the repository: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request

@devoncarew devoncarew merged commit dfc69a5 into dart-lang:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants