Skip to content

Conversation

@devoncarew
Copy link
Contributor

  • enable additional lints (mostly found via trying out package:dart_flutter_team_lints here, and temporarily turning on strict-casts here)
  • use a temp dir to avoid a test creating an UNUSED dir

Most of the rest of the strict cast violations look related to cli args parsing.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all so great, thanks!

/// An instance of this is returned if dartdoc fails in an expected way (for
/// instance, if there is an analysis error in the library).
class DartdocFailure {
class DartdocFailure implements Exception {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@srawlins srawlins merged commit 3931595 into dart-lang:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants