change from const to static-assets for the html and css assets dir #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/src/html_generator.dart
Outdated
There was a problem hiding this comment.
Is there a dependency on a version of the sdk for this? If so, we should update our sdk dep.
There was a problem hiding this comment.
good catch! I just saw the warning that dart:profiler was deprecated.
I'll update the SDK dep.
|
@devoncarew bumped SDK constraint |
|
lgtm! |
|
Hmm, we'll need to take out stable bot offline until 1.11 is stable. |
pubspec.yaml
Outdated
There was a problem hiding this comment.
also, it looks like the lower bounds will need to be a dev build - something like 1.11.0-dev.5.2
|
Reverted back to 1.9 for now. It's just a hint from analyzer, so for now, no big deal. Once 1.11 lands, we can switch over to dart:developer |
|
Fixed with b9860e3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.