Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Sep 5, 2023

As seen in https://github.com/dart-lang/native/actions/runs/6075163490/job/16511857492?pr=120, the publish.yaml seems to incorrectly retrieve the boolean value.

Fix it by using the JSON trick from health.yaml, tested using publish_internal.yaml.

CC @dcharkes


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

PR Health

Package publish validation ✔️

Details
Package Version Status
package:dart_flutter_team_lints 1.0.0 already published at pub.dev
package:firehose 0.3.27 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

@mosuem mosuem changed the title test workflow Fix boolean condition in publish.yaml Sep 5, 2023
Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ISSUE_NUMBER: ${{ github.event.number }}
PR_LABELS: "${{ join(github.event.pull_request.labels.*.name) }}"
run: dart pkgs/firehose/bin/firehose.dart --validate
run: dart pkgs/firehose/bin/firehose.dart --validate ${{ fromJSON('{"true":"--use-flutter","false":"--no-use-flutter"}')[env.use-flutter] }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary if env is always false?

Copy link
Member

@HosseinYousefi HosseinYousefi Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, the publish internal is for testing the trick.

I've seen the first commit test. Weird that the && doesn't work!

@HosseinYousefi HosseinYousefi marked this pull request as ready for review September 10, 2023 07:53
@HosseinYousefi HosseinYousefi merged commit 3fbab6c into main Sep 10, 2023
@HosseinYousefi HosseinYousefi deleted the testPublishFlutter branch September 10, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants