Skip to content

fix(cupertino_http): non-apple build#1927

Merged
brianquinlan merged 3 commits into
dart-lang:masterfrom
brianquinlan:apple_only
May 28, 2026
Merged

fix(cupertino_http): non-apple build#1927
brianquinlan merged 3 commits into
dart-lang:masterfrom
brianquinlan:apple_only

Conversation

@brianquinlan
Copy link
Copy Markdown
Collaborator


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@github-actions github-actions Bot added the package:cupertino_http Issues related to package:cupertino_http label May 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

Package publishing

Package Version Status Publish tag (post-merge)
package:cronet_http 1.9.0-wip WIP (no publish necessary)
package:cupertino_http 3.0.1 ready to publish cupertino_http-v3.0.1
package:http 1.6.1-wip WIP (no publish necessary)
package:http2 3.0.1-wip WIP (no publish necessary)
package:http_multi_server 3.2.2 already published at pub.dev
package:http_parser 4.1.3-wip WIP (no publish necessary)
package:http_profile 0.1.1-wip WIP (no publish necessary)
package:ok_http 0.1.1-wip WIP (no publish necessary)
package:web_socket 1.0.1 already published at pub.dev
package:web_socket_channel 3.0.4-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ⚠️
Package Status
cupertino_http
❗ Show Issues
These packages are used outside lib/ but are not dev_dependencies:
* flutter
* integration_test
These packages are only used outside lib/ and should be downgraded to dev_dependencies:
* code_assets
* hooks
* logging
* native_toolchain_c
These packages may be unused, or you may be using assets from these packages:
* dart_flutter_team_lints
Failed to update packages.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/cupertino_http/example/example.dart
pkgs/http/example/main.dart
pkgs/http_multi_server/test/cert.dart

This check can be disabled by tagging the PR with skip-license-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
cupertino_http Non-Breaking 3.0.0 3.0.1 3.1.0
Got "3.0.1" expected >= "3.1.0" (non-breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage ⚠️
File Coverage
pkgs/cupertino_http/hook/build.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@brianquinlan brianquinlan requested a review from liamappelbe May 27, 2026 19:06
@brianquinlan brianquinlan merged commit 8227c9d into dart-lang:master May 28, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:cupertino_http Issues related to package:cupertino_http

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cupertino_http] 3.0.0 Building Android faild

2 participants