Add support for some mmap.h functions #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianquinlan
commented
Oct 18, 2025
| @@ -0,0 +1,11 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
Contributor
Author
There was a problem hiding this comment.
I'm not happy with the word "handwritten". I've used "bespoke" before. Should I just use ".g" for generated files and use the obvious name for non-generated code? I thought that would be confusion e.g.
constants.cc
constants.dart
constants.g.cc
constants.g.dart
constants.g.h
constants.h
Or is that better?
There was a problem hiding this comment.
Using .g suffix for auto-generated files and no suffix/prefix for hand-written files looks good to me.
alexmarkov
approved these changes
Oct 22, 2025
| @@ -0,0 +1,11 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
Using .g suffix for auto-generated files and no suffix/prefix for hand-written files looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.