Make TOP_MERGE resolve to Object?
#904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
Mar 31, 2020
| - `NNBD_TOP_MERGE(dynamic, dynamic) = dynamic` | ||
| - `NNBD_TOP_MERGE(void, void) = void` | ||
| - `NNBD_TOP_MERGE(Object?, void) = void` | ||
| - `NNBD_TOP_MERGE(Object?, void) = Object?` |
There was a problem hiding this comment.
You generally use precedence, so would it be enough to write
NNBD_TOP_MERGE(x, y) = Object?, x, y in {void, Object?, dynamic}
(perhaps with an "otherwise" attached, or anx != y).
Not necessary, just perhaps easier to understand.
lrhn
approved these changes
Mar 31, 2020
eernstg
approved these changes
Mar 31, 2020
|
Tests for member signatures out for review here |
This was referenced Apr 8, 2020
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 8, 2020
Tests for member signature resolution as specified in this change: dart-lang/language#904 Change-Id: I7ee81dd1927b8f9419082f9bd2cbec14f0a5c0f0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142802 Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the specification of NNBD_TOP_MERGE to resolve any conflicting top types to
Object?, per discussion here.Initial set of tests here, more to follow.
[Edit: more tests here]
cc @eernstg @munificent @lrhn