Skip to content

[jnigen] Fixed an issue with how java.io.File is created #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucaskimnz wants to merge 3 commits into from
Closed

[jnigen] Fixed an issue with how java.io.File is created #2196

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62dd361
Fixed an issue with how java.io.File is created
pointbre Apr 12, 2025
dfe1a33
Instruction updated
pointbre Apr 12, 2025
8515e8b
Followed up PR comments
May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkgs/jnigen/example/pdfbox_plugin/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ class PDFInfoAppState extends State<PDFInfoApp> {
pdfs.add(item.path);
} else if (isDir) {
Copy link
Member

@HosseinYousefi HosseinYousefi Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

@lucaskimnz lucaskimnz Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the example app shows all of directories even if the app aims to show the summary of pdf files found in $HOME directory. I thought better to exclude directories and included only pdf files.

Copy link
Member

@HosseinYousefi HosseinYousefi Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't created this example so I don't know what has been the purpose of this. I'm fine with not removing these lines as it doesn't make the example non-functional.

Feel free to open another PR that deletes this line (and cleans the unused variables as a result of your change) that explains why you are making this change. I'd rather this PR remains focused on solving the bug that you fixed.

Copy link
Contributor Author

@lucaskimnz lucaskimnz May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed another changes to follow up your PR comments. Please review again.

dirs.add(item.path);
}
}
setState(() {
_isLoading = false;
Expand Down Expand Up @@ -158,9 +157,10 @@ class PDFFileInfo {
// Since java.io is not directly available, use package:jni API to
// create a java.io.File object.
final fileClass = JClass.forName("java/io/File");
final inputFile = fileClass
.constructorId("(Ljava/lang/String;)V")
.call(fileClass, JObject.type, [filename]);
final fileConstructor = fileClass.constructorId("(Ljava/lang/String;)V");
final inputFile = fileConstructor(
fileClass, JObject.type, [JString.fromString(filename)]);

// Static method call PDDocument.load -> PDDocument
final pdf = PDDocument.load(inputFile)!;
// Instance method call getNumberOfPages() -> int
Expand Down