Skip to content

Conversation

@dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Aug 18, 2025

Recognize the script is running on GitHub and act accordingly:

@github-actions
Copy link

github-actions bot commented Aug 18, 2025

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
hooks Breaking 0.20.0 0.20.1-wip 0.21.0
Got "0.20.1-wip" expected >= "0.21.0" (breaking changes)
⚠️
hooks_runner Breaking 0.22.0 0.22.1-wip 0.23.0
Got "0.22.1-wip" expected >= "0.23.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Aug 18, 2025

Coverage Status

coverage: 71.971%. remained the same
when pulling ef2f043 on ci-tweaks
into 38b3789 on main.

@dcharkes dcharkes marked this pull request as ready for review August 18, 2025 15:41
_runProcess('dart', ['test', ...testUris]);
_runProcess('dart', [
'test',
if (Platform.environment['GITHUB_ACTIONS'] != null) '--reporter=github',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about this flag!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's working though. I see no difference in the CI...

Copy link
Member

@HosseinYousefi HosseinYousefi Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dart test --help says that it's the default on github CI so maybe it already picks up the env variable.

[github]                    A custom reporter for GitHub Actions (the default reporter when running on GitHub Actions).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any difference with a local run though? Or is it different in the fact that the local run does this replace-the-last-line?

@auto-submit auto-submit bot merged commit 22eac2d into main Aug 18, 2025
30 checks passed
@auto-submit auto-submit bot deleted the ci-tweaks branch August 18, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants