-
Notifications
You must be signed in to change notification settings - Fork 82
[infra] Make CI script GitHub aware #2505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| hooks | Breaking | 0.20.0 | 0.20.1-wip | 0.21.0 Got "0.20.1-wip" expected >= "0.21.0" (breaking changes) |
|
| hooks_runner | Breaking | 0.22.0 | 0.22.1-wip | 0.23.0 Got "0.22.1-wip" expected >= "0.23.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/jni/lib/src/third_party/generated_bindings.dart |
| pkgs/objective_c/lib/src/ns_input_stream.dart |
| _runProcess('dart', ['test', ...testUris]); | ||
| _runProcess('dart', [ | ||
| 'test', | ||
| if (Platform.environment['GITHUB_ACTIONS'] != null) '--reporter=github', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about this flag!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's working though. I see no difference in the CI...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dart test --help says that it's the default on github CI so maybe it already picks up the env variable.
[github] A custom reporter for GitHub Actions (the default reporter when running on GitHub Actions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any difference with a local run though? Or is it different in the fact that the local run does this replace-the-last-line?
Recognize the script is running on GitHub and act accordingly: