Skip to content

[infra] Make CI script GitHub aware #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

[infra] Make CI script GitHub aware #2505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c8c305
[infra] Make CI script GitHub aware
dcharkes Aug 18, 2025
ef2f043
another skip
dcharkes Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkgs/hooks/test/example/native_dynamic_linking_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ void main() async {

test(
'native_dynamic_linking build',
skip: Platform.isMacOS || Platform.isWindows
skip:
(Platform.isMacOS || Platform.isWindows) &&
Platform.environment['GITHUB_ACTIONS'] != null
? 'https://github.com/dart-lang/native/issues/2501'
: false,
() async {
Expand Down
5 changes: 5 additions & 0 deletions pkgs/hooks_runner/test/test_data/native_dynamic_linking_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ void main() async {

test(
'native_dynamic_linking build',
skip:
(Platform.isMacOS || Platform.isWindows) &&
Platform.environment['GITHUB_ACTIONS'] != null
? 'https://github.com/dart-lang/native/issues/2501'
: false,
() => inTempDir((tempUri) async {
final buildOutputUri = tempUri.resolve('build_output.json');
var outputDirectory = tempUri.resolve('out/');
Expand Down
6 changes: 5 additions & 1 deletion tool/ci.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ void main(List<String> arguments) async {

if (argResults['test'] as bool) {
final testUris = getTestUris(packages);
_runProcess('dart', ['test', ...testUris]);
_runProcess('dart', [
'test',
if (Platform.environment['GITHUB_ACTIONS'] != null) '--reporter=github',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about this flag!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's working though. I see no difference in the CI...

Copy link
Member

@HosseinYousefi HosseinYousefi Aug 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dart test --help says that it's the default on github CI so maybe it already picks up the env variable.

[github]                    A custom reporter for GitHub Actions (the default reporter when running on GitHub Actions).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any difference with a local run though? Or is it different in the fact that the local run does this replace-the-last-line?

...testUris,
]);
}

if (argResults['example'] as bool) {
Expand Down
Loading