Skip to content

Conversation

@josxha
Copy link

@josxha josxha commented Nov 8, 2025

This pr exports a missing class and some enums used by the FfiGenerator.

Caution: The class Version comes from the pub_semver package. In general I'd say exporting an external class introduces some risk in case the package does not follow semantic versioning. In this case however it is a tools.dart.dev package, so in my opinion the risk is neglectable.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@josxha josxha changed the title fix missing export of some classes used in the FfiGenerator [ffigen] fix missing export of some classes used in the FfiGenerator Nov 8, 2025
@josxha josxha changed the title [ffigen] fix missing export of some classes used in the FfiGenerator [ffigen] fix missing exports used in the FfiGenerator Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Interop EAP] Missing exports used in FfiGenerator (ffigen v20.0.0)

1 participant