-
Notifications
You must be signed in to change notification settings - Fork 87
[infra] add ffigen, objective_c, ffi to workspace #2834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with
API leaks
|
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| ffi | MallocAllocator | allocation.dart::malloc |
| ffi | CallocAllocator | allocation.dart::calloc |
| objective_c | _FinalizablePointer | internal.dart::_ObjCReference::new::_finalizable |
This check can be disabled by tagging the PR with skip-leaking-check.
Breaking changes ⚠️
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| code_assets | None | 1.0.0 | 1.0.0 | 1.0.0 | ✔️ |
| data_assets | None | 0.19.6 | 0.19.6 | 0.19.6 | ✔️ |
| ffi | None | 2.1.4 | 2.1.5-wip | 2.1.4 | ✔️ |
| hooks | None | 1.0.0 | 1.0.0 | 1.0.0 | ✔️ |
| hooks_runner | None | 1.0.1 | 1.0.2-wip | 1.0.1 | ✔️ |
| native_toolchain_c | None | 0.17.4 | 0.17.4 | 0.17.4 | ✔️ |
| objective_c | Non-Breaking | 9.2.1 | 9.2.1 | 9.2.2 Got "9.2.1" expected >= "9.2.2" (non-breaking changes --> patch) |
This check can be disabled by tagging the PR with skip-breaking-check.
|
Yes! I've wanted this for a long time! Is this already possible? We fixed the test concurrency recently. But I don't believe we fixed yet that the tests have 0 output if they pass? Or did we? I don't remember if we had other open issues why merging doesn't work yet. We should have a github issue somewhere. What about merging the CI workflows? The ffigen and objective_c tests should be taken into account in |
|
I am still iterating over this to see what the remaining blockers are. I only found #1223, which didn't seem document any remaining issues... Stay tuned! |
fc07472 to
d1eb37c
Compare
e7085ec to
7261e43
Compare
undo some bumps fix lint Revert "fix lint" This reverts commit 450eb88.
2ab2246 to
149463b
Compare
149463b to
c76bb61
Compare
|
Note to future self:
|
No description provided.