Skip to content

Conversation

@goderbauer
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/hooks_runner/test_data/download_assets/hook/build.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
ffi MallocAllocator allocation.dart::malloc
ffi CallocAllocator allocation.dart::calloc
objective_c _FinalizablePointer internal.dart::_ObjCReference::new::_finalizable

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
code_assets None 1.0.0 1.0.0 1.0.0 ✔️
data_assets None 0.19.6 0.19.6 0.19.6 ✔️
ffi None 2.1.4 2.1.5-wip 2.1.4 ✔️
hooks None 1.0.0 1.0.0 1.0.0 ✔️
hooks_runner None 1.0.1 1.0.2-wip 1.0.1 ✔️
native_toolchain_c None 0.17.4 0.17.4 0.17.4 ✔️
objective_c Non-Breaking 9.2.1 9.2.1 9.2.2
Got "9.2.1" expected >= "9.2.2" (non-breaking changes --> patch)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

@goderbauer goderbauer changed the title [ffigen][ffi][objective_c] add to workspace [infra] add to workspace Nov 28, 2025
@goderbauer goderbauer changed the title [infra] add to workspace [infra] add ffigen, objective_c, ffi to workspace Nov 28, 2025
@coveralls
Copy link

coveralls commented Nov 28, 2025

Coverage Status

coverage: 81.978%. remained the same
when pulling c76bb61 on goderbauer:ffiworkspace
into 579b84d on dart-lang:main.

@dcharkes
Copy link
Collaborator

Yes! I've wanted this for a long time!

Is this already possible?

We fixed the test concurrency recently. But I don't believe we fixed yet that the tests have 0 output if they pass? Or did we? I don't remember if we had other open issues why merging doesn't work yet. We should have a github issue somewhere.

What about merging the CI workflows? The ffigen and objective_c tests should be taken into account in tools/ci.dart (ditto for formatting, analyzing etc.)

@goderbauer
Copy link
Contributor Author

I am still iterating over this to see what the remaining blockers are. I only found #1223, which didn't seem document any remaining issues... Stay tuned!

undo some bumps

fix lint

Revert "fix lint"

This reverts commit 450eb88.
@goderbauer
Copy link
Contributor Author

Note to future self:

  • something is still broken with running ffigen and objective-c tests on macos in the native workflow
  • Need to clean up the ffigen and objective_c workflows (some of their stuff is now performed by the native workflow)
  • (likely unrelated to this PR): tests for native_toolchain_c are failing on MacOS and coverage upload is failing across platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants