Conversation
|
For my own understanding: How will this work? You define the analyzer plugins in your top-level pubspec and then they automatically apply to sub-packages as well? Or do the sub-packages have to import the top-level pubspec? If so, how does that work on pub when these packages are analyzes without the workspace present? |
| @@ -0,0 +1 @@ | |||
| include: package:dart_flutter_team_lints/analysis_options.yaml | |||
There was a problem hiding this comment.
How is this resolved? I would have expected that we'd need an entry for this in the top-level pubspec?
tool/ci.dart
Outdated
| 'pkgs/hooks_runner', | ||
| 'pkgs/native_toolchain_c', | ||
| ]; | ||
| const slowTestPackages = ['pkgs/hooks_runner', 'pkgs/native_toolchain_c']; |
There was a problem hiding this comment.
Ah! You need to add the following to the analysis_options to preserve trailing commas and avoid this reformat:
formatter:
trailing_commas: preserve
I believe so. You can't add them to nested ones, that gives an error. FYI: I abandoned analyzer plugins for now. But I still think it could make sense to land this analysis options to govern the tool directory. |
dcharkes
force-pushed
the
toplevel-analysis-options
branch
2 times, most recently
from
0aa3a26 to
9456e73
Compare
dcharkes
force-pushed
the
toplevel-analysis-options
branch
from
9456e73 to
53f61a6
Compare
3 participants
Analyzer plugins need to be defined in the toplevel analysis options, we don't have one yet.