Conversation
|
So why is the license header check that we have on github not enough to catch this and we need to implement our own thing? |
|
Also, Windows is unhappy. |
f7009df to
ddc08a6
Compare
I can't run that check locally. I can't tell contributors to run that check locally. It doesn't work in any If you have any ideas on how to un github-i-fy the dart-lang/ecosystem checks so we can run them easily with a script locally, I'd be happy for that as an alternative. |
|
Okay, but why didn't that check catch the missing license headers? Is it broken? Are we running the license checker now twice on CI (this one and the one from the github actions) with different sources of truth of what the license should look like? |
ddc08a6 to
b3015fd
Compare
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with |
I believe it blanket ignores
Should we disable the ecosystem one? As I will add non-Dart license header checks to this one. |
b3015fd to
f146809
Compare
This enables running (and fixing automatically) locally.
The ecosystem check is skipping
builddirectories: https://github.com/dart-lang/ecosystem/blob/main/pkgs/firehose/lib/src/health/license.dart This caused the CI to miss: #3113Also, we should add license checks to non-dart files (follow up PR).
So, lets run this on the CI here on GitHub as well.