Skip to content

[record_use] Store multiple loading units#3122

Merged
dcharkes merged 1 commit intomainfrom
record-use-multiple-loading-units
Feb 19, 2026
Merged

[record_use] Store multiple loading units#3122
dcharkes merged 1 commit intomainfrom
record-use-multiple-loading-units

Conversation

@dcharkes
Copy link
Collaborator

@github-actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
record_use Breaking 0.4.2 0.5.0-wip 0.5.0-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/test/debug_release_test.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

1 similar comment
@github-actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
record_use Breaking 0.4.2 0.5.0-wip 0.5.0-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/test/debug_release_test.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

) => switch (syntax) {
TearoffCallSyntax() => CallTearoff(
loadingUnit: context.loadingUnits[syntax.loadingUnitIndex],
loadingUnit: context.loadingUnits[syntax.loadingUnitIndices.first],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own understanding (here and elsewhere): Why's it always the first index?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See follow up PR. I wanted to split the JSON update from the Dart API update. The Dart API becomes a list in the next PR.

@dcharkes dcharkes requested a review from goderbauer February 19, 2026 13:15
Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes merged commit 3879dca into main Feb 19, 2026
31 checks passed
@dcharkes dcharkes deleted the record-use-multiple-loading-units branch February 19, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments