[objective_c] Implement NSNumber methods for bool#3331
[objective_c] Implement NSNumber methods for bool#3331knopp wants to merge 2 commits intodart-lang:mainfrom
Conversation
|
Not sure why there are so many changes in generated bindings, is that expected? |
PR HealthAPI leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
liamappelbe
left a comment
There was a problem hiding this comment.
I think technically renaming NSNumberIsFloat is a breaking change, even though it's unlikely to actually affect any users. But just to be safe, it would be better to add a separate NSNumberIsBool interface.
As for the bindings diffs, no, they're not expected. I suspect you're using a different version of xcode than me and the github bot. Some of the diffs look problematic too. Are you able to update your xcode?
Adds
bool.toNSNumber()extension method,NSNumber.isBoolcheck and add converter support for bool.Related Issues
List which issues are fixed by this PR. Use the syntax
Fixes #1234.PR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).