Skip to content

[ffigen] feat: generate cpp class destructor bindings#3399

Open
Hassnaa9 wants to merge 3 commits into
dart-lang:mainfrom
Hassnaa9:generate-cpp-distructor-bindings
Open

[ffigen] feat: generate cpp class destructor bindings#3399
Hassnaa9 wants to merge 3 commits into
dart-lang:mainfrom
Hassnaa9:generate-cpp-distructor-bindings

Conversation

@Hassnaa9
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

Package publishing

Package Version Status Publish tag (post-merge)
package:code_assets 1.2.0 already published at pub.dev
package:data_assets 0.20.0 already published at pub.dev
package:ffi 2.2.0 already published at pub.dev
package:hooks 2.0.0 already published at pub.dev
package:hooks_runner 1.4.0 already published at pub.dev
package:jni_flutter 1.0.1 already published at pub.dev
package:native_toolchain_c 0.19.1 already published at pub.dev
package:record_use 0.6.1-wip WIP (no publish necessary)
package:swift2objc 0.2.0 already published at pub.dev
package:swiftgen 0.1.3 ready to publish swiftgen-v0.1.3

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link
Copy Markdown

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

s.write('\nexternal $ptrVoid $glue($ffiParams);\n\n');
}

if (destructor != null) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be factorized with the generator for the other two kinds of method?

);
}

void _parseDestructor(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also feels like it could be factorized with the others

@Hassnaa9 Hassnaa9 requested a review from liamappelbe May 29, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants