Test for known license range matches. #1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Sep 25, 2025
| license.content, | ||
| relativePath: 'LICENSE', | ||
| ); | ||
| // TODO: fix detection and return at least one match |
Contributor
There was a problem hiding this comment.
Please open an issue and attach the issue url here.
sigurdm
reviewed
Sep 25, 2025
| .where((l) => l.spdxIdentifier == license.identifier) | ||
| .single; | ||
|
|
||
| // TODO: fix coverage calculation as 1:1 matches shouldn't have too many ranges |
sigurdm
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1481
Note: I'm not sure if the fix would be simple or complex, submitting the verification test separately for now.