Verify JWT token signature using JWKs list. #5897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Jul 5, 2022
isoos
commented
- Allow publishing from github #5769
- Only the RSA algorithm is recognized/implemented, other algorithms will not be verified.
- Uses the ASN.1 encoder to create a PEM public key, and openssl to verify the text input + signature with the key.
sigurdm
approved these changes
Jul 7, 2022
| return false; | ||
| } | ||
| return await verifyTextWithRsaSignature( | ||
| input: input, |
There was a problem hiding this comment.
Would it have made more sense for verifyTextWithRsaSignature to take a Uint8list - i guess the thing is base64-encoded and thus it should not matter much - it just seems fragile to decode and reencode when you verify a signature...
There was a problem hiding this comment.
verifyTextWithRsaSignature is using openssl, and there is no further encoding: the input will be written into a file, and the file is being verified. We could use Uint8List too, but here the input is really the concatenated token parts, without further coding with base64... I think we should keep it like this for now.
Co-authored-by: Sigurd Meldgaard <sigurdm@google.com>
… construction time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.