Skip to content

Fix serving of dartdoc's search.svg. #8468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix serving of dartdoc's search.svg. #8468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions pkg/pub_integration/lib/src/test_browser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,6 @@ class TestBrowserSession {
await rq.continueRequest();
return;
}
// TODO: this file is missing, we may need to fix it in the dartdoc stylesheet
if (rq.url.endsWith('/css/search.svg')) {
await rq.respond(
status: 200,
body: '',
contentType: 'image/svg+xml',
headers: {'Cache-Control': 'public, max-age=604800'},
);
return;
}

final uri = Uri.parse(rq.url);
if (uri.path.contains('//')) {
Expand Down
5 changes: 5 additions & 0 deletions pkg/web_css/lib/dartdoc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,8 @@
.light-theme .markdown-body pre {
background-color: #f6f8fa;
}

/* Note: override for the image path, as the dartdoc.css is served from /static/hash-<hash>/css/ */
input.typeahead {
background-image: url('../dartdoc/resources/search.svg');
}
Loading