Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ Important changes to data models, configuration, and migrations between each
AppEngine version, listed here to ease deployment and troubleshooting.

## Next Release (replace with git tag when deployed)
* Bump runtimeVersion to `2025.10.07`.
* Bump runtimeVersion to `2025.10.10`.
* Upgraded stable Dart analysis SDK to `3.9.4`
* Upgraded dartdoc to `9.0.0`.
* Upgraded pana to `0.22.24`.

## `20251002t093000-all`
* Bump runtimeVersion to `2025.09.30`.
Expand Down
4 changes: 2 additions & 2 deletions app/lib/shared/versions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ final RegExp runtimeVersionPattern = RegExp(r'^\d{4}\.\d{2}\.\d{2}$');
/// when the version switch happens.
const _acceptedRuntimeVersions = <String>[
// The current [runtimeVersion].
'2025.10.07',
'2025.10.10',
// Fallback runtime versions.
'2025.09.30',
'2025.09.22',
Expand Down Expand Up @@ -76,4 +76,4 @@ final semanticToolStableFlutterSdkVersion = Version.parse(
final String panaVersion = pana.packageVersion;

// keep in-sync with pkg/pub-worker/lib/src/bin/pana_wrapper.dart
final String dartdocVersion = '8.3.4';
final String dartdocVersion = '9.0.0';
2 changes: 1 addition & 1 deletion app/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ dependencies:
watcher: ^1.0.0
yaml: ^3.1.0
# pana version to be pinned
pana: '0.22.23'
pana: '0.22.24'
# 3rd-party packages with pinned versions
mailer: '6.5.0'
postgres: '3.5.8'
Expand Down
2 changes: 1 addition & 1 deletion app/test/task/end2end_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import '../shared/utils.dart';
const String goldenDir = 'test/task/testdata/goldens';

// TODO: generalize golden testing, use env var for regenerating all goldens.
final _regenerateGoldens = false;
final _regenerateGoldens = true;

// We use a small test profile without flutter packages, because we have to
// run pana+dartdoc for all these package versions, naturally this is slow.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ <h2>Constructors</h2>
<dl class="constructor-summary-list">
<dt id="MainClass.new" class="callable">
<span class="name">
<a href="../oxygen/MainClass/MainClass.html">MainClass.new</a>
<a href="../oxygen/MainClass/MainClass.html">MainClass</a>
</span>
<span class="signature">
(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ <h2>Constructors</h2>
<dl class="constructor-summary-list">
<dt id="MainClass.new" class="callable">
<span class="name">
<a href="../oxygen/MainClass/MainClass.html">MainClass.new</a>
<a href="../oxygen/MainClass/MainClass.html">MainClass</a>
</span>
<span class="signature">
(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ <h2>Constructors</h2>
<dl class="constructor-summary-list">
<dt id="MainClass.new" class="callable">
<span class="name">
<a href="../oxygen/MainClass/MainClass.html">MainClass.new</a>
<a href="../oxygen/MainClass/MainClass.html">MainClass</a>
</span>
<span class="signature">
(
Expand Down
25 changes: 2 additions & 23 deletions pkg/pub_worker/lib/src/bin/pana_wrapper.dart
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const _totalTimeout = Duration(minutes: 50);

/// The dartdoc version to use.
/// keep in-sync with app/lib/shared/versions.dart
const _dartdocVersion = '8.3.4';
const _dartdocVersion = '9.0.0';

/// Program to be used as subprocess for running pana, ensuring that we capture
/// all the output, and only run analysis in a subprocess that can timeout and
Expand Down Expand Up @@ -131,31 +131,10 @@ Future<void> main(List<String> args) async {
);

// sanity check on pana report size
var reportSize = gzip
final reportSize = gzip
.encode(utf8.encode(json.encode(summary.toJson())))
.length;

// Note: the new license coverage data seems to generate coverage pairs that
// occupy way too much space. Until that bug is fixed, we should remove
// that data from the summary.
// TODO: remove this block once https://github.com/dart-lang/pana/issues/1481 gets fixed and deployed
if (reportSize > _reportSizeDropThreshold) {
// We are storing the licenses in two fields, removing the fallback/unused one.
// ignore: deprecated_member_use
summary.licenses?.clear();

// Remove excessive range data.
for (final l in summary.result?.licenses ?? <License>[]) {
final count = l.range?.coverages.length ?? 0;
if (count > 50) {
l.range?.coverages.removeRange(50, count);
}
}

// re-calculate report size
reportSize = gzip.encode(utf8.encode(json.encode(summary.toJson()))).length;
}

if (reportSize > _reportSizeDropThreshold) {
summary = Summary(
createdAt: summary.createdAt,
Expand Down
2 changes: 1 addition & 1 deletion pkg/pub_worker/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
appengine: ^0.13.6
json_annotation: ^4.3.0
jsontool: ^2.0.0
pana: ^0.22.23
pana: ^0.22.24
path: ^1.8.0
lints: ^6.0.0 # required for pana
meta: ^1.7.0
Expand Down
4 changes: 2 additions & 2 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -621,10 +621,10 @@ packages:
dependency: transitive
description:
name: pana
sha256: e3bd09f4aa7eb997ac9d19d6df82781a92fb48917ddb2637b4cb7430e25de735
sha256: bbad5a3e085fcc2475f08fe1240041e25d74482da80d9af00bc17cce99989e29
url: "https://pub.dev"
source: hosted
version: "0.22.23"
version: "0.22.24"
path:
dependency: transitive
description:
Expand Down