Skip to content

Extend pub_worker-related NotFound exception with additional context. #9047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

Extend pub_worker-related NotFound exception with additional context. #9047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/lib/task/backend.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,9 @@ class TaskBackend {

final state = await _db.tasks.lookupOrNull(package);
if (state == null) {
throw NotFoundException.resource('$package/$version');
throw NotFoundException.resource(
'PackageState($runtimeVersion/$package)',
Copy link
Contributor

@sigurdm sigurdm Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to also include the version here?

Copy link
Collaborator Author

@isoos isoos Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lookup above depends only on the runtimeVersion and the package name, the version check comes only later. I think removing the version from the message makes it better focused on the operation.

Copy link
Contributor

@sigurdm sigurdm Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair

);
}
final versionState = _authorizeWorkerCallback(
package,
Expand Down Expand Up @@ -686,7 +688,9 @@ class TaskBackend {
await withRetryTransaction(_db, (tx) async {
final state = await tx.tasks.lookupOrNull(package);
if (state == null) {
throw NotFoundException.resource('$package/$version');
throw NotFoundException.resource(
'PackageState($runtimeVersion/$package)',
);
}
final versionState = _authorizeWorkerCallback(
package,
Expand Down