Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 3, 2025

  • Creates new methods inside _TaskDataAccess (listFinishedSince, selectSomePending) following the previous query refactor patterns to make the eventual SQL-migration simpler.
  • Updated updatePackageStateWithPendingVersions to take a package name instead of PackageState.
  • Updated updatePackageStateWithPendingVersions to return the previous state's versions Map in case we need to revert it.
  • most of the schedule method's change is coming from the query method refactor + the subsequent indent, however, there is a noteworthy update: instead of a fully asynchronous scheduleMicrotask(() async {, we now use await Future.microtask, I think it fits the method's Future.wait wrapper better.
  • The related transactions will be refactored in a subsequent PR.

@isoos isoos requested a review from sigurdm November 3, 2025 12:15
@isoos isoos merged commit 704b8b9 into dart-lang:master Nov 3, 2025
45 of 46 checks passed
@isoos isoos deleted the refactor-db branch November 3, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants