Refactor scan-packages loop kernel to enable direct call. #9102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Dec 2, 2025
app/lib/task/backend.dart
Outdated
| } | ||
|
|
||
| @visibleForTesting | ||
| Future<void> runOneIterationOfBackgroundLoops() async { |
Collaborator
Author
There was a problem hiding this comment.
Not yet, but tests will use this. I first wanted to also unroll the scheduling loops in this PR, but its a lot things that will be moved, but kept it for now.
Contributor
There was a problem hiding this comment.
Why not just expose the actual _runOneScanPackagesUpdate function to tests? It seems more honest to test that than some wrapper that is otherwise not used in production.
Collaborator
Author
There was a problem hiding this comment.
Removing for now. Wanted to keep it as a placeholder for the name, but can re-add later.
sigurdm
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScanPackagesUpdatedStateas a field onTaskBackend.