Change getRange to sublist. Make getRange deprecated.

This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5

Author: lrhn

pkg/analyzer_experimental/lib/src/generated/java_core.dart

@@ -313,9 +313,9 @@ class ListWrapper<E> extends Collection<E> implements List<E> {
 
   Iterable<E> get reversed => elements.reversed;
 
-  List<E> getRange(int start, int length) {
-    return elements.getRange(start, length);
-  }
+  List<E> sublist(int start, [int end]) => elements.sublist(start, end);
+
+  List<E> getRange(int start, int length) => sublist(start, start + length);
 
   void setRange(int start, int length, List<E> from, [int startFrom]) {
     elements.setRange(start, length, from, startFrom);

pkg/intl/lib/src/date_format_helpers.dart

@@ -98,7 +98,7 @@ class _Stream {
           min(index + howMany, contents.length));
     } else {
       // Assume List
-      result = contents.getRange(index, howMany);
+      result = contents.sublist(index, index + howMany);
     }
     return result;
   }

pkg/intl/test/date_time_format_test_core.dart

@@ -184,7 +184,7 @@ List oddLocales() {
  * Return a set of a few locales to run just the tests on a small sample.
  */
 List smallSetOfLocales() {
-  return allLocales().getRange(0,10);
+  return allLocales().sublist(0,10);
 }
 
 /**

pkg/scheduled_test/lib/src/descriptor/directory.dart

@@ -62,7 +62,7 @@ class Directory extends descriptor.Entry {
         throw "Found multiple entries named '${split.first}' within "
             "$nameDescription.";
       } else {
-        var remainingPath = split.getRange(1, split.length - 1);
+        var remainingPath = split.sublist(1);
         if (remainingPath.isEmpty) {
           return matchingEntries.first.read();
         } else {

runtime/lib/array.dart

@@ -82,15 +82,20 @@ class _ObjectArray<E> implements List<E> {
         "Cannot insert range in a non-extendable array");
   }
 
-  List<E> getRange(int start, int length) {
-    if (length == 0) return [];
-    Arrays.rangeCheck(this, start, length);
+
+  List<E> sublist(int start, [int end]) {
+    Arrays.indicesCheck(this, start, end);
+    if (end == null) end = this.length;
+    int length = end - start;
+    if (start == end) return [];
     List list = new _GrowableObjectArray<E>.withCapacity(length);
     list.length = length;
     Arrays.copy(this, start, list, 0, length);
     return list;
   }
 
+  List<E> getRange(int start, int length) => sublist(start, start + length);
+
   // Iterable interface.
 
   bool contains(E element) {
@@ -325,15 +330,19 @@ class _ImmutableArray<E> implements List<E> {
         "Cannot insert range in an immutable array");
   }
 
-  List<E> getRange(int start, int length) {
-    if (length == 0) return [];
-    Arrays.rangeCheck(this, start, length);
+  List<E> sublist(int start, [int end]) {
+    Arrays.indicesCheck(this, start, end);
+    if (end == null) end = this.length;
+    int length = end - start;
+    if (start == end) return [];
     List list = new List<E>();
     list.length = length;
     Arrays.copy(this, start, list, 0, length);
     return list;
   }
 
+  List<E> getRange(int start, int length) => sublist(start, start + length);
+
   // Collection interface.
 
   bool contains(E element) {