Implement missing functions on ListBase.

Review URL: https://codereview.chromium.org//12380086

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19382 260f80e4-7a28-3924-810f-c04153c831b5

Author: floitschG

sdk/lib/_collection_dev/list.dart

@@ -24,6 +24,31 @@ abstract class ListBase<E> extends ListIterable<E> implements List<E> {
   E elementAt(int index) {
     return this[index];
   }
+
+  List<E> getRange(int start, int length) {
+    if (start < 0 || start > this.length) {
+      throw new RangeError.range(start, 0, this.length);
+    }
+    if (length < 0 || start + length > this.length) {
+      throw new RangeError.range(length, 0, this.length - start);
+    }
+    List<E> result = new List<E>(length);
+    for (int i = 0; i < length; i++) {
+      result[i] = this[start + i];
+    }
+    return result;
+  }
+
+  int indexOf(E element, [int start = 0]) {
+    return Arrays.indexOf(this, element, start, this.length);
+  }
+
+  int lastIndexOf(E element, [int start = null]) {
+    if (start == null) start = length - 1;
+    return Arrays.lastIndexOf(this, element, start);
+  }
+
+  Iterable<E> get reversed => new ReversedListIterable(this);
 }
 
 /**
@@ -86,6 +111,11 @@ abstract class FixedLengthListBase<E> extends ListBase<E> {
         "Cannot remove from a fixed-length list");
   }
 
+  void retainMatching(bool test(E element)) {
+    throw new UnsupportedError(
+        "Cannot remove from a fixed-length list");
+  }
+
   void clear() {
     throw new UnsupportedError(
         "Cannot clear a fixed-length list");
@@ -162,6 +192,11 @@ abstract class UnmodifiableListBase<E> extends ListBase<E> {
         "Cannot remove from an unmodifiable list");
   }
 
+  void retainMatching(bool test(E element)) {
+    throw new UnsupportedError(
+        "Cannot remove from an unmodifiable list");
+  }
+
   void sort([Comparator<E> compare]) {
     throw new UnsupportedError(
         "Cannot modify an unmodifiable list");
@@ -196,20 +231,6 @@ abstract class UnmodifiableListBase<E> extends ListBase<E> {
     throw new UnsupportedError(
         "Cannot insert range in an unmodifiable list");
   }
-
-  List<E> getRange(int start, int length) {
-    if (start < 0 || start > this.length) {
-      throw new RangeError.range(start, 0, this.length);
-    }
-    if (length < 0 || start + length > this.length) {
-      throw new RangeError.range(length, 0, this.length - start);
-    }
-    List<E> result = new List<E>(length);
-    for (int i = 0; i < length; i++) {
-      result[i] = this[start + i];
-    }
-    return result;
-  }
 }
 
 /** An empty fixed-length list. */

tests/corelib/corelib.status

@@ -41,6 +41,8 @@ string_base_vm_test: Fail, OK # VM specific test.
 
 string_replace_func_test: Skip # Bug 6554 - doesn't terminate.
 
+string_codeunits_test: Fail # Issue 8904
+
 [ $compiler == dart2js && $runtime == none ]
 *: Fail, Pass # TODO(ahe): Triage these tests.
 

tests/corelib/string_codeunits_test.dart

@@ -25,8 +25,36 @@ main() {
     // .map
     Expect.listEquals(expectedUnits.map((x) => x.toRadixString(16)).toList(),
                       units.map((x) => x.toRadixString(16)).toList());
+
+    if (s == "") {
+      Expect.throws(() => units.first, (e) => e is StateError);
+      Expect.throws(() => units.last, (e) => e is StateError);
+      Expect.throws(() => units[0], (e) => e is RangeError);
+      Expect.throws(() => units[0] = 499, (e) => e is UnsupportedError);
+      Expect.listEquals([], units.getRange(0, 0));
+      Expect.equals(-1, units.indexOf(42));
+      Expect.equals(-1, units.lastIndexOf(499));
+    } else {
+      Expect.equals(s.codeUnitAt(0), units.first);
+      Expect.equals(s.codeUnitAt(s.length - 1), units.last);
+      Expect.equals(s.codeUnitAt(0), units[0]);
+      Expect.throws(() { units[0] = 499; }, (e) => e is UnsupportedError);
+      List<int> sub = units.getRange(1, units.length - 1);
+      Expect.listEquals(s.substring(1, s.length).codeUnits, sub);
+      Expect.equals(-1, units.indexOf(-1));
+      Expect.equals(0, units.indexOf(units[0]));
+      Expect.equals(-1, units.lastIndexOf(-1));
+      Expect.equals(units.length - 1, units.lastIndexOf(units[units.length - 1]));
+    }
+
+    Iterable reversed = units.reversed;
+    int i = units.length - 1;
+    for (int codeUnit in reversed) {
+      Expect.equals(units[i--], codeUnit);
+    }
   }
 
+  test("");
   test("abc");
   test("\x00\u0000\u{000000}");
   test("\u{ffff}\u{10000}\u{10ffff}");