Version 3.8.0-212.0.dev

Merge 4551003 into dev

Author: Dart CI

pkg/_fe_analyzer_shared/test/flow_analysis/reachability/data/unreachable_via_never.dart

@@ -50,7 +50,7 @@ void nonNullAssert(Null Function() f) {
 }
 
 void nullAwareAccess(Null Function() f, Object? Function() g) {
-  f()?.extensionMethod(/*unreachable*/ 1);
+  f()?./*analyzer.unreachable*/extensionMethod(/*unreachable*/ 1);
   g()?.extensionMethod(2);
 }
 

pkg/analysis_server/benchmark/integration/input_converter.dart

@@ -19,7 +19,7 @@ import 'operation.dart';
 
 /// Common input converter superclass for sharing implementation.
 abstract class CommonInputConverter extends Converter<String, Operation?> {
-  static final ERROR_PREFIX = 'Server responded with an error: ';
+  static const _errorPrefix = 'Server responded with an error: ';
   final Logger logger = Logger('InstrumentationInputConverter');
   final Set<String> eventsSeen = <String>{};
 
@@ -172,8 +172,8 @@ abstract class CommonInputConverter extends Converter<String, Operation?> {
     var result = exception;
     if (exception is UnimplementedError) {
       var message = exception.message;
-      if (message!.startsWith(ERROR_PREFIX)) {
-        result = json.decode(message.substring(ERROR_PREFIX.length));
+      if (message!.startsWith(_errorPrefix)) {
+        result = json.decode(message.substring(_errorPrefix.length));
       }
     }
     processResponseResult(id, result);

pkg/analysis_server/benchmark/integration/instrumentation_input_converter.dart

@@ -11,11 +11,11 @@ import 'package:logging/logging.dart';
 import 'input_converter.dart';
 import 'operation.dart';
 
-final int COLON = ':'.codeUnitAt(0);
-
 /// [InstrumentationInputConverter] converts an instrumentation stream
 /// into a series of operations to be sent to the analysis server.
 class InstrumentationInputConverter extends CommonInputConverter {
+  static final _colon = ':'.codeUnitAt(0);
+
   final Set<String> codesSeen = <String>{};
 
   /// [readBuffer] holds the contents of the file being read from disk
@@ -109,10 +109,10 @@ class InstrumentationInputConverter extends CommonInputConverter {
     var sb = StringBuffer();
     while (index < line.length) {
       var code = line.codeUnitAt(index);
-      if (code == COLON) {
+      if (code == _colon) {
         // Embedded colons are doubled
         var next = index + 1;
-        if (next < line.length && line.codeUnitAt(next) == COLON) {
+        if (next < line.length && line.codeUnitAt(next) == _colon) {
           sb.write(':');
           ++index;
         } else {

pkg/analysis_server/benchmark/integration/log_file_input_converter.dart

@@ -10,30 +10,31 @@ import 'package:logging/logging.dart';
 import 'input_converter.dart';
 import 'operation.dart';
 
-const CONNECTED_MSG_FRAGMENT = ' <= {"event":"server.connected"';
-const RECEIVED_FRAGMENT = ' <= {';
-const SENT_FRAGMENT = ' => {';
-final int NINE = '9'.codeUnitAt(0);
-final int ZERO = '0'.codeUnitAt(0);
-
 /// [LogFileInputConverter] converts a log file stream
 /// into a series of operations to be sent to the analysis server.
 class LogFileInputConverter extends CommonInputConverter {
+  static const _connectedMsgFragment = ' <= {"event":"server.connected"';
+  static const _receivedFragment = ' <= {';
+  static const _sentFragment = ' => {';
+
+  static final _nine = '9'.codeUnitAt(0);
+  static final _zero = '0'.codeUnitAt(0);
+
   LogFileInputConverter(super.tmpSrcDirPath, super.srcPathMap);
 
   @override
   Operation? convert(String line) {
     try {
       var timeStampString = _parseTimeStamp(line);
       var data = line.substring(timeStampString.length);
-      if (data.startsWith(RECEIVED_FRAGMENT)) {
+      if (data.startsWith(_receivedFragment)) {
         var jsonData = asMap(json.decode(data.substring(4)));
         if (jsonData.containsKey('event')) {
           return convertNotification(jsonData);
         } else {
           return convertResponse(jsonData);
         }
-      } else if (data.startsWith(SENT_FRAGMENT)) {
+      } else if (data.startsWith(_sentFragment)) {
         var jsonData = asMap(json.decode(data.substring(4)));
         if (jsonData.containsKey('method')) {
           return convertRequest(jsonData);
@@ -56,9 +57,9 @@ class LogFileInputConverter extends CommonInputConverter {
   static bool isFormat(String line) {
     var timeStampString = _parseTimeStamp(line);
     var start = timeStampString.length;
-    var end = start + CONNECTED_MSG_FRAGMENT.length;
+    var end = start + _connectedMsgFragment.length;
     return (10 < start && end < line.length) &&
-        line.substring(start, end) == CONNECTED_MSG_FRAGMENT;
+        line.substring(start, end) == _connectedMsgFragment;
   }
 
   /// Parse the given line and return the millisecond timestamp or `null`
@@ -67,7 +68,7 @@ class LogFileInputConverter extends CommonInputConverter {
     var index = 0;
     while (index < line.length) {
       var code = line.codeUnitAt(index);
-      if (code < ZERO || NINE < code) {
+      if (code < _zero || _nine < code) {
         return line.substring(0, index);
       }
       ++index;

pkg/analysis_server/lib/protocol/protocol.dart

@@ -291,10 +291,6 @@ abstract class RequestOrResponse {
 ///
 /// Clients may not extend, implement or mix-in this class.
 class Response extends RequestOrResponse {
-  /// The [Response] instance that is returned when a real [Response] cannot
-  /// be provided at the moment.
-  static final Response DELAYED_RESPONSE = Response('DELAYED_RESPONSE');
-
   /// The name of the JSON attribute containing the id of the request for which
   /// this is a response.
   static const String ID = 'id';

pkg/analysis_server/lib/src/computer/computer_highlights.dart

@@ -2,6 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Many functions here are mostly camelcase, with an occasional underscore to
+// separate phrases.
+// ignore_for_file: non_constant_identifier_names
+
 import 'dart:math' as math;
 
 import 'package:_fe_analyzer_shared/src/parser/quote.dart'

pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_editable_arguments.dart

@@ -42,6 +42,10 @@ class EditableArgumentsHandler
     MessageInfo message,
     CancellationToken token,
   ) async {
+    if (!isDartDocument(params.textDocument)) {
+      return success(null);
+    }
+
     var textDocument = params.textDocument;
     var position = params.position;
 

pkg/analysis_server/lib/src/protocol_server.dart

@@ -2,6 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Many functions here are mostly camelcase, with an occasional underscore to
+// separate phrases.
+// ignore_for_file: non_constant_identifier_names
+
 import 'package:analysis_server/plugin/protocol/protocol_dart.dart';
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analysis_server/src/computer/computer_color.dart';

pkg/analysis_server/lib/src/services/completion/dart/identifier_helper.dart

@@ -60,9 +60,9 @@ class IdentifierHelper {
       return;
     }
     for (var childElement in state.libraryElement.children2) {
-        if (childElement.name3 == candidateName) {
-          // Don't suggest a name that's already declared in the library.
-          return;
+      if (childElement.name3 == candidateName) {
+        // Don't suggest a name that's already declared in the library.
+        return;
       }
     }
     var matcherScore = state.matcher.score(candidateName);

pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart

@@ -2,6 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Many functions here are mostly camelcase, with an occasional underscore to
+// separate phrases.
+// ignore_for_file: non_constant_identifier_names
+
 import 'dart:math';
 
 import 'package:analysis_server/src/protocol_server.dart' hide Element;
@@ -129,7 +133,7 @@ class StatementCompletionKind {
 
 /// The computer for Dart statement completions.
 class StatementCompletionProcessor {
-  static final NO_COMPLETION = StatementCompletion(
+  static final _noCompletion = StatementCompletion(
     DartStatementCompletion.NO_COMPLETION,
     SourceChange('', edits: []),
   );
@@ -167,13 +171,13 @@ class StatementCompletionProcessor {
   Future<StatementCompletion> compute() async {
     var node = _selectedNode();
     if (node == null) {
-      return NO_COMPLETION;
+      return _noCompletion;
     }
     node = node.thisOrAncestorMatching(
       (n) => n is Statement || _isNonStatementDeclaration(n),
     );
     if (node == null) {
-      return _complete_simpleEnter() ? completion! : NO_COMPLETION;
+      return _complete_simpleEnter() ? completion! : _noCompletion;
     }
     if (node is Block) {
       if (node.statements.isNotEmpty) {
@@ -227,7 +231,7 @@ class StatementCompletionProcessor {
     if (_complete_simpleEnter()) {
       return completion!;
     }
-    return NO_COMPLETION;
+    return _noCompletion;
   }
 
   void _addInsertEdit(int offset, String text) {