Fix some corelib tests.

R=lrn@google.com

Review URL: https://codereview.chromium.org//55533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29757 260f80e4-7a28-3924-810f-c04153c831b5

Author: floitschG

tests/corelib/collection_to_string_test.dart

@@ -241,8 +241,8 @@ populateRandomCollection(int size, bool exact,
         if (startIndex - start > MAX_LENGTH - 6) {  // Limit - ", ...)".length.
           String prefix = stringRep.toString().substring(0, startIndex);
           stringRep.clear();
-          stringRep.add(prefix);
-          stringRep.add(", ...");
+          stringRep.write(prefix);
+          stringRep.write(", ...");
         }
       }
     } else if (stringRep.length - start > MAX_LENGTH - 1) {  // 80 - ")".length.

tests/corelib/corelib.status

@@ -107,18 +107,10 @@ list_as_map_test: Pass, Slow # TODO(kasperl): Please triage.
 compare_to2_test: Fail # inherited from VM
 unicode_test: Fail # inherited from VM
 
-# Library changes
-[ $compiler == none || $compiler == dart2js || $compiler == dart2dart ]
-map_keys2_test: RuntimeError # Generic types aren't right.
-
-[ $compiler == dart2js ]
-map_values2_test: RuntimeError # Generic types aren't right
-
-## Tests failing after merge of experimental library branch.
 [ $compiler == dart2js ]
-# Tests fail due to bug in generics on constants, issue 6827
-iterable_to_list_test: RuntimeError
-iterable_to_set_test: RuntimeError
+map_values2_test: RuntimeError # Issue 8210
+iterable_to_list_test: RuntimeError # Issue 8210
+iterable_to_set_test: RuntimeError # Issue 8210
 
 [ $compiler == dart2dart && $minified ]
 error_stack_trace1_test: Fail # Fails in minified mode, test depends on method names.
@@ -155,12 +147,8 @@ collection_length_test: Pass, Timeout
 collection_to_string_test: Pass, Crash # Issue: 11207
 
 [ $compiler == dartanalyzer || $compiler == dart2analyzer ]
-collection_to_string_test: StaticWarning
-error_stack_trace_test: StaticWarning
-iterable_element_at_test: StaticWarning
-iterable_test: StaticWarning
-list_map_test: StaticWarning
-num_clamp_test: StaticWarning
-queue_test: StaticWarning
-string_codeunits_test: StaticWarning
-string_test: StaticWarning
+error_stack_trace_test: StaticWarning, OK # Test generates errors on purpose.
+iterable_element_at_test: StaticWarning, OK # Test generates errors on purpose.
+num_clamp_test: StaticWarning, OK # Test generates errors on purpose.
+queue_test: StaticWarning # Issue 12274.
+string_test: StaticWarning, OK # Test generates error on purpose.

tests/corelib/iterable_test.dart

@@ -9,7 +9,7 @@ import "package:expect/expect.dart";
 
 import 'dart:collection';
 
-class MyIterable implements IterableBase {
+class MyIterable extends IterableBase {
   get iterator => [].iterator;
 }
 

tests/corelib/list_map_test.dart

@@ -20,7 +20,7 @@ void testOperations() {
   // Function that reverses l and r lists when used to map.
   int rev(x) => 11 - x;
   // A base list that starts out like l, but isn't const.
-  Iterable base = l.map((x) => x).toList();
+  List base = l.map((x) => x).toList();
 
   Iterable reversed = l.map(rev);
 

tests/corelib/map_keys2_test.dart

@@ -15,16 +15,16 @@ main() {
   var map6 = new Map<String, bool>();
 
   Expect.isTrue(map1.keys is Iterable<String>);
-  Expect.isFalse(map1.keys is Iterable<bool>);
+  Expect.isTrue(map1.keys is Iterable<bool>);
 
   Expect.isTrue(map2.keys is Iterable<String>);
-  Expect.isFalse(map2.keys is Iterable<bool>);
+  Expect.isTrue(map2.keys is Iterable<bool>);
 
   Expect.isTrue(map3.keys is Iterable<String>);
-  Expect.isFalse(map3.keys is Iterable<bool>);
+  Expect.isTrue(map3.keys is Iterable<bool>);
 
   Expect.isTrue(map4.keys is Iterable<String>);
-  Expect.isFalse(map4.keys is Iterable<bool>);
+  Expect.isTrue(map4.keys is Iterable<bool>);
 
   Expect.isTrue(map5.keys is Iterable<String>);
   Expect.isFalse(map5.keys is Iterable<bool>);

tests/corelib/string_codeunits_test.dart

@@ -6,7 +6,7 @@ import "package:expect/expect.dart";
 
 main() {
   test(String s) {
-    Iterable<int> units = s.codeUnits;
+    List<int> units = s.codeUnits;
     List<int> expectedUnits = <int>[];
     for (int i = 0; i < s.length; i++) {
       expectedUnits.add(s.codeUnitAt(i));