Skip to content

Commit f6ca2c1

Browse files
munificentcommit-bot@chromium.org
authored andcommitted
Remove the Dart 1 tests.
This deletes: tests/co19 tests/corelib tests/html tests/isolate tests/language tests/lib It does not delete tests/standalone because apparently there are tests in there that are not in standalone_2. (I assume they were added after the test migration. I don't know why they were added there.) I have tried to remove references to the old tests from various scripts and tools but may have missed some. (As you can imagine, grepping for "lib" does not have the best signal-to-noise ratio.) "It was a pleasure to burn. It was a special pleasure to see things eaten, to see things blackened and changed. With the brass nozzle in his fists, with this great python spitting its venomous kerosene upon the world, the blood pounded in his head, and his hands were the hands of some amazing conductor playing all the symphonies of blazing and burning to bring down the tatters and charcoal ruins of history." - Ray Bradbury, Fahrenheit 451 Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e Reviewed-on: https://dart-review.googlesource.com/c/75420 Commit-Queue: Bob Nystrom <rnystrom@google.com> Auto-Submit: Bob Nystrom <rnystrom@google.com> Reviewed-by: William Hesse <whesse@google.com> Reviewed-by: Terry Lucas <terry@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
1 parent 9f98f5f commit f6ca2c1

File tree

3,360 files changed

+27
-353329
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

3,360 files changed

+27
-353329
lines changed

.gitattributes

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -18,36 +18,18 @@ tests/compiler/dart2js_extra/eof_line_ending_test.dart -text
1818
tests/compiler/dart2js_extra/string_interpolation_test.dart -text
1919
tests/compiler/dart2js_extra/string_interpolation_dynamic_test.dart -text
2020
tests/compiler/dart2js_extra/literal_string_juxtaposition_test.dart -text
21-
tests/language/raw_string_test.dart -text
22-
tests/language/multiline_strings_test.dart -text
23-
tests/language/multiline_newline_cr.dart -text
24-
tests/language/multiline_newline_crlf.dart -text
25-
tests/language/multiline_newline_lf.dart -text
2621
tests/language_2/raw_string_test.dart -text
2722
tests/language_2/multiline_strings_test.dart -text
2823
tests/language_2/multiline_newline_cr.dart -text
2924
tests/language_2/multiline_newline_crlf.dart -text
3025
tests/language_2/multiline_newline_lf.dart -text
31-
tests/lib/convert/json_pretty_test.dart -text
3226
tests/lib_2/convert/json_pretty_test.dart -text
33-
tests/lib/mirrors/method_mirror_source_line_ending_test.dart -text
34-
tests/lib/mirrors/method_mirror_source_line_ending_cr.dart -text
35-
tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart -text
36-
tests/lib/mirrors/method_mirror_source_line_ending_lf.dart -text
37-
tests/lib/mirrors/method_mirror_source_test.dart -text
38-
tests/lib/mirrors/method_mirror_source_other.dart -text
39-
tests/lib_2/mirrors/method_mirror_source_line_ending_test.dart -text
4027
tests/lib_2/mirrors/method_mirror_source_line_ending_cr.dart -text
4128
tests/lib_2/mirrors/method_mirror_source_line_ending_crlf.dart -text
4229
tests/lib_2/mirrors/method_mirror_source_line_ending_lf.dart -text
43-
tests/lib_2/mirrors/method_mirror_source_test.dart -text
44-
tests/lib_2/mirrors/method_mirror_source_other.dart -text
4530
tests/lib_2/mirrors/method_mirror_source_line_ending_test.dart -text
46-
tests/lib_2/mirrors/method_mirror_source_line_ending_cr.dart -text
47-
tests/lib_2/mirrors/method_mirror_source_line_ending_crlf.dart -text
48-
tests/lib_2/mirrors/method_mirror_source_line_ending_lf.dart -text
49-
tests/lib_2/mirrors/method_mirror_source_test.dart -text
5031
tests/lib_2/mirrors/method_mirror_source_other.dart -text
32+
tests/lib_2/mirrors/method_mirror_source_test.dart -text
5133

5234
# Files to leave alone and not diff.
5335
*.png binary

DEPS

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ vars = {
3636
"chromium_git": "https://chromium.googlesource.com",
3737
"fuchsia_git": "https://fuchsia.googlesource.com",
3838

39-
"co19_rev": "9858ee7d79cf09b50d6b5bc13fb950ae5f357954",
4039
"co19_2_rev": "9484b81650d8c5bedf72abc541960dd1c90b2329",
4140

4241
# As Flutter does, we pull buildtools, including the clang toolchain, from
@@ -175,9 +174,6 @@ deps = {
175174
"dep_type": "cipd",
176175
},
177176

178-
Var("dart_root") + "/tests/co19/src":
179-
Var("dart_git") + "co19.git" + "@" + Var("co19_rev"),
180-
181177
Var("dart_root") + "/tests/co19_2/src":
182178
Var("chromium_git") + "/external/github.com/dart-lang/co19.git" +
183179
"@" + Var("co19_2_rev"),

PRESUBMIT.py

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -107,78 +107,6 @@ def HasFormatErrors(filename=None, contents=None):
107107
return []
108108

109109

110-
def _CheckNewTests(input_api, output_api):
111-
testsDirectories = [
112-
# Dart 1 tests Dart 2.0 tests
113-
# ================= ==========================
114-
("tests/language/", "tests/language_2/"),
115-
("tests/corelib/", "tests/corelib_2/"),
116-
("tests/lib/", "tests/lib_2/"),
117-
("tests/html/", "tests/lib_2/html/"),
118-
("tests/isolate/", "tests/lib_2/isolate/")
119-
]
120-
121-
result = []
122-
# Tuples of (new Dart 1 test path, expected Dart 2.0 test path)
123-
dart1TestsAdded = []
124-
# Tuples of (original Dart test path, expected Dart 2.0 test path)
125-
dart2TestsExists = []
126-
for f in input_api.AffectedTextFiles():
127-
localpath = f.LocalPath()
128-
if not(localpath.endswith('.status')):
129-
for oldPath, newPath in testsDirectories:
130-
if localpath.startswith(oldPath):
131-
if f.Action() == 'A':
132-
# Compute where the new test should live.
133-
dart2TestPath = localpath.replace(oldPath, newPath)
134-
dart1TestsAdded.append((localpath, dart2TestPath))
135-
elif f.Action() == 'M':
136-
# Find all modified tests in Dart 1.0
137-
for oldPath, newPath in testsDirectories:
138-
if localpath.find(oldPath) == 0:
139-
dart2TestFilePathAbs = "%s" % \
140-
f.AbsoluteLocalPath().replace(oldPath, newPath)
141-
if os.path.isfile(dart2TestFilePathAbs):
142-
#originalDart1Test.append(localpath)
143-
dart2TestsExists.append((localpath,
144-
localpath.replace(oldPath, newPath)))
145-
146-
# Does a Dart 2.0 test exist if so it must be changed too.
147-
missingDart2TestsChange = []
148-
for (dartTest, dart2Test) in dart2TestsExists:
149-
foundDart2TestModified = False
150-
for f in input_api.AffectedFiles():
151-
if f.LocalPath() == dart2Test:
152-
# Found corresponding Dart 2 test - great.
153-
foundDart2TestModified = True
154-
break
155-
if not foundDart2TestModified:
156-
# Add the tuple (dart 1 test path, Dart 2.0 test path)
157-
missingDart2TestsChange.append((dartTest, dart2Test))
158-
159-
if missingDart2TestsChange:
160-
errorList = []
161-
for idx, (orginalTest, dart2Test) in enumerate(missingDart2TestsChange):
162-
errorList.append(
163-
'%s. Dart 1.0 test changed: %s\n%s. Only the Dart 2.0 test can '\
164-
'change: %s\n' % (idx + 1, orginalTest, idx + 1, dart2Test))
165-
result.append(output_api.PresubmitError(
166-
'Error: Changed Dart 1.0 test detected - only 1.0 status files can '\
167-
'change. Migrate test to Dart 2.0 tests:\n%s' % ''.join(errorList)))
168-
169-
if dart1TestsAdded:
170-
errorList = []
171-
for idx, (oldTestPath, newTestPath) in enumerate(dart1TestsAdded):
172-
errorList.append('%s. New Dart 1.0 test: %s\n'
173-
'%s. Should be Dart 2.0 test: %s\n' % \
174-
(idx + 1, oldTestPath, idx + 1, newTestPath))
175-
result.append(output_api.PresubmitError(
176-
'Error: New Dart 1.0 test can not be added the test must be added '\
177-
'as a Dart 2.0 test:\nFix tests:\n%s' % ''.join(errorList)))
178-
179-
return result
180-
181-
182110
def _CheckStatusFiles(input_api, output_api):
183111
local_root = input_api.change.RepositoryRoot()
184112
upstream = input_api.change._upstream
@@ -244,13 +172,11 @@ def _CheckValidHostsInDEPS(input_api, output_api):
244172
def CheckChangeOnCommit(input_api, output_api):
245173
return (_CheckValidHostsInDEPS(input_api, output_api) +
246174
_CheckBuildStatus(input_api, output_api) +
247-
_CheckNewTests(input_api, output_api) +
248175
_CheckDartFormat(input_api, output_api) +
249176
_CheckStatusFiles(input_api, output_api))
250177

251178

252179
def CheckChangeOnUpload(input_api, output_api):
253180
return (_CheckValidHostsInDEPS(input_api, output_api) +
254-
_CheckNewTests(input_api, output_api) +
255181
_CheckDartFormat(input_api, output_api) +
256182
_CheckStatusFiles(input_api, output_api))

pkg/compiler/tool/status_files/update_all.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@ const List<String> strongSuites = const <String>[
1717
const List<String> nonStrongSuites = const <String>[
1818
'dart2js_native',
1919
'dart2js_extra',
20-
'language',
21-
'corelib',
22-
'html',
2320
];
2421

2522
main(List<String> args) {

pkg/compiler/tool/status_files/update_from_log.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,12 @@ final dart2jsConfigurations = {
4545
};
4646

4747
final dart2jsStatusFiles = {
48-
'language': 'tests/language/language_dart2js.status',
49-
'corelib': 'tests/corelib/corelib.status',
5048
'language_2': 'tests/language_2/language_2_dart2js.status',
5149
// TODO(sigmund,rnystrom): update when corelib_2 gets split into multiple
5250
// status files.
5351
'corelib_2': 'tests/corelib_2/corelib_2.status',
5452
'dart2js_extra': 'tests/compiler/dart2js_extra/dart2js_extra.status',
5553
'dart2js_native': 'tests/compiler/dart2js_native/dart2js_native.status',
56-
'html': 'tests/html/html.status',
5754
};
5855

5956
main(args) {

tests/co19/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/co19/co19-analyzer.status

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)