Frog broken in SDK

[DartBot]

This issue was originally filed by darren.j....@gmail.com

---

What steps will reproduce the problem?

1. Download 64-bit version (listed below) of the editor from dartlang.org
2. Attempt to compile a sample (such as sunflower)
3. Observe that the compilation fails because the path to html_frog.dart is wrong.

For example:
C:\Program Files\dart\dart\dart-sdk\lib\html\html_frog.dart
but the compiler is looking for it at:
C:\Program Files\dart\dart\dart-sdk\lib\html\frog\html_frog.dart

What is the expected output? What do you see instead?
Expected successful compilation. Instead confronted with error message regarding path to html_frog.dart.

org.eclipse.core.runtime.CoreException: Failure to launch - unable to generate JavaScript for sunflower.html.

error: File not found: C:/Program Files/dart/dart/dart-sdk/lib/html/frog/html_frog.dart
compilation failed with 1 errors
Compilation failed
Failure to launch - unable to generate JavaScript for sunflower.html.

error: File not found: C:/Program Files/dart/dart/dart-sdk/lib/html/frog/html_frog.dart
compilation failed with 1 errors
Compilation failed

What version of the product are you using? On what operating system?
Dart Editor: Version 0.1.0.201203131146, Build 5427
Dart SDK: Version 5425
Dartium not installed.
Windows 7 Professional, Service Pack 1.

Please provide any additional information below.
Easy fix was to create the frog folder and move the file down into it, but irritating.

[madsager]

Added Triaged label.

[keertip]

Set owner to @keertip.

[keertip]

Issue #2138 has been merged into this issue.

[keertip]

Frog needs to be modified to look at the right place in the dart-sdk for the library files. frog is called from the editor to generate javascript using the following

/pathTo/dart-sdk/bin/dart --new_gen_heap_size=256
/pathTo/dart-sdk/bin/frogc.dart --compile-only --suppress_warnings --no_colors
--libdir=/pathTo/dart-sdk/lib --out=/pathTo/samples/sunflower/Sunflower.dart.js /pathTo/samples/sunflower/Sunflower.dart

Compilation error :

error: File not found: /pathTo/dart-sdk/lib/html/frog/html_frog.dart

Frog is looking for the file at lib/html/frog whereas the file is in /lib/html folder.

The dart-sdk structure is

..dart-sdk/

....bin/

......dart or dart.exe (executable)

......frogc.dart

......frogsh (coming later)

....lib/

......builtin/

........builtin_runtime.dart

......io/

........io_runtime.dart

........runtime/

......core/

........core_{frog, runtime}.dart

........{frog, runtime}/

......coreimpl/

........coreimpl_{frog, runtime}.dart

........{frog, runtime}/

......dartdoc/

......isolate/

........isolate_{frog, runtime}.dart

........{frog, runtime}/

......dom/

........dom.dart

......frog/

......html/

........html_frog.dart

........html_dartium.dart

......json/

........json_frog.dart

#.........json.dart

........{frog}/

......uri/

........uri.dart

......utf/

......(more will come here)

....util/

......(more will come here)

---

Removed the owner.
Removed Area-Editor label.
Added Area-Frog label.

[danrubel]

@john:
Could you look into this?
One thing that would help alleviate issues like these in the future would be to run all Frog tests from within the SDK.

---

Set owner to @jmesserly.
Changed the title to: "Frog broken in SDK".

[jmesserly]

Set owner to @danrubel.

[danrubel]

@kasper
This is a fairly high priority bug I'm hoping we can fix. We can't launch on Windows (no Dartium yet) without a fix or workaround. If necessary, we can work around the problem by duplicating the html_frog.dart file in the SDK for now.
Please let me know.

---

Set owner to @kasperl.

[sethladd]

Issue #2170 has been merged into this issue.

[efortuna]

Fixed in revision 5488

---

Set owner to @efortuna.
Added Fixed label.

[kasperl]

Thanks a lot, Emily! Really appreciate it.