Config specific exports don't work with analyzer/ddc

[jakemac53]

Example gist https://gist.github.com/jakemac53/2d7449e8002589f2f93a828c5bf41915

Given a structure like the gist above, I get an error like this:

Error compiling dartdevc module:_test|web/main.ddc.js

[error] Undefined name 'platform'. (/web/main.dart, line 10, col 9)

Please fix all errors before compiling (warnings are okay).

So it doesn't appear that anything is actually being exported.

Note that in this scenario the platform.dart file does live in a separate module - so it could be an error on the analysis summary side of things. It does work in my IDE and I can click through to the definition (it goes to the default.dart import).

cc @jmesserly @vsmenon @leafpetersen

[jakemac53]

I will check next week if this issue is present with kernel/ddk as well - if it isn't we might be able to skip fixing it.

[jakemac53]

Looks like I get a different error for DDK so I can't test this properly right now, will follow up.

[jmesserly]

Yeah we haven't implemented anything specific for this on DDC side (because Analyzer/CFE should resolve it for us). I don't know how config specific imports/exports are implemented in Analyzer though. It might require a flag to enable the feature?

[jakemac53]

It might be that this is a bug in the analyzer summaries or something... @stereotype441 any ideas?

[stereotype441]

No ideas off the top of my head. Even though config specific imports/exports aren't fully implemented in the analyzer IIRC, your example seems like it should work anyhow, since even if you disregard the config-specific imports, the name platform should be resolvable in default.dart.

Note that in your gist, default.dart has a compile-time error (missing ;). I'm assuming that's an unrelated problem.

[yjbanov]

Added customer-flutter label as it might be the cause of flutter/flutter#27668 (comment). Feel free to remove the label if I'm wrong.

[natebosch]

cc @stereotype441 - we're getting new user reports about this. Can we prioritize a fix?