Not always able to rename `extension type E` using "rename symbol"

[matanlurey]

I am not sure if this is specific to VSCode, I'd imagine it's an LSP/Analysis server thing.

Workspace Environment

Dart Code extension: 3.86.0

App: Visual Studio Code
App Host: desktop
Version: mac 1.88.1

Workspace type: Dart (LSP)

Dart (3.3.1): /opt/homebrew/Caskroom/flutter/3.19.3/flutter/bin/cache/dart-sdk
Flutter (3.19.3): /opt/homebrew/Caskroom/flutter/3.19.3/flutter (No device)

extension type Foo(int v) {
  Foo.bar() : this(0);

  Foo get baz => Foo(0);
}

Imagine I want to rename this from Foo to Bar, so I right-click Foo and hit "rename symbol".

It works sometimes, but not other times - here is what I see:

1. ✅ Right-click Foo in extension type Foo(int v) { ... }:

   

2. ❌ Select Foo first, and then right-click/rename:

   Note that foo is selected, unlike in (1) where I've highlighted/selected nothing:

   

   v is accidentally selected as what I intended to rename, instead of Foo:

   

3. ❌ Right-click Foo in Foo.bar() : this(0):

   

   bar is accidentally selected as what I intended to rename, instead of Foo:

   

[bwilkerson]

@scheglov

[scheglov]

2. It looks that LSP version leans right.
3. Renaming the constructor instead of the class in Foo.bar() : this(0) is a feature.

[matanlurey]

3. Renaming the constructor instead of the class in Foo.bar() : this(0) is a feature.

Ah interesting, it looks like this is how it works for all constructors.

I do think it's confusing though, for default constructors it works as expected:

But selecting the class prefix in a named constructor assumes I want to rename the constructor:

[bwilkerson]

I agree that it's a little confusing, but it's the best UX we could find for renaming the unnamed constructor. And making it work differently, depending on whether the constructor was named or not, seemed even more confusing.

Suggestions for a better UX are welcome.

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/363481

[matanlurey]

I agree that it's a little confusing, but it's the best UX we could find for renaming the unnamed constructor. And making it work differently, depending on whether the constructor was named or not, seemed even more confusing.

Suggestions for a better UX are welcome.

I think selecting the LHS should select the class not the constructor. I also don't think it's a huge problem that needs solving.

Thanks!

[matanlurey]

Appreciate the quick fixes!