Skip to content

Import library combinator fixes should consider lint and multiple combinators #60131

@FMorschel

Description

@FMorschel

This is basically a revisiting of IMPORT_LIBRARY_COMBINATOR and IMPORT_LIBRARY_COMBINATOR_MULTIPLE. I've made them work with both hide and show previously. Now after completing #56830 I was reminded by @bwilkerson that we should update more than one combinator (if the user has it) so the code actually works.

Today both fixes are hard-coded to a single combinator so the idea is to make them work if you have multiple.

I also added support in the same commit for the combinators_ordering lint so I'd like to be coherent here too and follow its ruling for sorting the combinators.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3A lower priority bug or feature requestarea-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.devexp-quick-fixIssues with analysis server (quick) fixestype-enhancementA request for a change that isn't a bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions