Failures on [dart2wasm] web/wasm_js_shared/env_defines_test

[jyameo]

There are new test failures on [dart2wasm] Fix handling of --define/-D.

The tests

web/wasm_js_shared/env_defines_test Fail (expected Pass)

are failing on configurations

dart2wasm-linux-optimized-jsc
ddc-win-chrome

LOGS:

• https://dart-ci.appspot.com/log/dart2wasm-linux-optimized-jsc/dart2wasm-linux-optimized-jsc/2128/web/wasm_js_shared/env_defines_test
• https://dart-ci.appspot.com/log/any/ddc-win-chrome/9426/web/wasm_js_shared/env_defines_test

[osa1]

The dart2wasm-linux-optimized-jsc failure is fixed with the commit referenced above.

[osa1]

@jyameo how do I test ddc-win-chrome on CI? When I run it on Gerrit I get hundreds of failures, I think the test results of that configuration is not up-to-date: https://dart-review.googlesource.com/c/sdk/+/416700 (click on "aggregated test results").

[jyameo]

@nshahan @bkonyi Could you take a look at this and provide some guidance to @osa1?

[nshahan]

@osa1
Requesting ddc-win-chrome on CI is the right way to run the config, we don't have any special processes. It is just only configured to run on post submit.

It looks like that config started failing with a change that you landed yesterday.
https://dart-review.googlesource.com/c/sdk/+/415280
All of the results changes from their previous status (Pass, RuntimeError, CompileTimeError, etc) to Crash.

Regarding the results on https://dart-review.googlesource.com/c/sdk/+/416700, it looks to me like your fix is working and the results are changing from Crash back to whatever they were previously.

I'll ping you in a chat for more details.