Unable to run "gclient sync" - "FormatException: Could not parse 3" on Windows

[DanTup]

I suspect this might just be a me problem, but I haven't managed to track down what's up yet. I pulled the latest changes from the SDK repo and now trying to run gclient sync -D fails with the error below.

PS D:\Dev\Google\dart-sdk\sdk\pkg\analysis_server> gclient sync -D
Updating depot_tools...
Syncing projects: 100% (60/60), done.

________ running 'python3 sdk/tools/generate_package_config.py' in 'D:\Dev\Google\dart-sdk'
`pub get` failed
".rmatException: Could not parse "3
#0      new Version.parse (package:pub_semver/src/version.dart:124:7)
#1      new DartSdk.<anonymous closure> (package:pub/src/sdk/dart.dart:70:20)
#2      new DartSdk (package:pub/src/sdk/dart.dart:71:4)
#3      sdk (package:pub/src/sdk.dart:63:13)
#4      sdk (package:pub/src/sdk.dart)
#5      PubCommand.run (package:pub/src/command.dart:193:21)
#6      CommandRunner.runCommand (package:args/command_runner.dart:212:27)
#7      DartdevRunner.runCommand (package:dartdev/dartdev.dart:247:30)
#8      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:122:25)
#9      new Future.sync (dart:async/future.dart:315:27)
#10     CommandRunner.run (package:args/command_runner.dart:122:14)
#11     runDartdev (package:dartdev/dartdev.dart:47:29)
#12     main (file:///C:/b/s/w/ir/x/w/sdk/pkg/dartdev/bin/dartdev.dart:13:11)
#13     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:311:33)
#14     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:194:12)



Error: Command 'python3 sdk/tools/generate_package_config.py' returned non-zero exit status 4294967295 in D:\Dev\Google\dart-sdk
`pub get` failed
".rmatException: Could not parse "3
#0      new Version.parse (package:pub_semver/src/version.dart:124:7)
#1      new DartSdk.<anonymous closure> (package:pub/src/sdk/dart.dart:70:20)
#2      new DartSdk (package:pub/src/sdk/dart.dart:71:4)
#3      sdk (package:pub/src/sdk.dart:63:13)
#4      sdk (package:pub/src/sdk.dart)
#5      PubCommand.run (package:pub/src/command.dart:193:21)
#6      CommandRunner.runCommand (package:args/command_runner.dart:212:27)
#7      DartdevRunner.runCommand (package:dartdev/dartdev.dart:247:30)
#8      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:122:25)
#9      new Future.sync (dart:async/future.dart:315:27)
#10     CommandRunner.run (package:args/command_runner.dart:122:14)
#11     runDartdev (package:dartdev/dartdev.dart:47:29)
#12     main (file:///C:/b/s/w/ir/x/w/sdk/pkg/dartdev/bin/dartdev.dart:13:11)
#13     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:311:33)
#14     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:194:12)

I'm not sure at this point where the version it's trying to parse is, nor am I sure why the error looks malformed (".rmatException: Could not parse "3).

I will try to dig and post back what I find, but I'm filing this in case it turns out to not be just me (or if it is just me, for future benefit of anyone else that manages to break things the way I have).

[DanTup]

I don't know why the printing is bad, but I've figured this out - it's because I have \r\n in my copy of tools/VERSION and the generate_package_config.dart script splits on \n but then leaves \rs in the parsed values. Not sure why this just started happening, but I'll open a fix to make this script handle both line endings.

[DanTup]

I guess it started happening with 9e1ae23. I've opened a fix at https://dart-review.googlesource.com/c/sdk/+/421222 (@sigurdm @athomas I added you as reviewers since you wrote/reviewed the previous change - lmk if this isn't the right way to solve this).

Edit: Fix link

[DanTup]

This does raise a question... why did none of the bots break? Are the git settings such that the line endings can be different between the bots and my machine? If so, should they be made explicit in the repo gitattributes so that things are consistent between users/bots?

[lrhn]

I'll open a fix to make this script handle both line endings.

Use LineSplitter, it is \r\n aware.
While you are there, consider;

  final lines = LineSplitter.split(versionContents);
  final versionParts = {
    for (var line in lines)
      if (!line.isEmpty && !line.startsWith('#'))
        if (line.split(' ') case [final key, final value])
          key: value
  };

[DanTup]

Use LineSplitter, it is \r\n aware.

Ah, I didn't realise it has a static split method. Done, thanks!

While you are there, consider;

Edit: Also done :)