Failures on [VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization

[alexmarkov]

There are new test failures on [VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization.

The tests

ffi/regress_47594_test Fail (expected Pass)

are failing on configurations

vm-aot-fuchsia-release-x64
vm-fuchsia-release-x64

Log:

--- Command "vm" (took 02.000543s):
DART_CONFIGURATION=ReleaseFuchsiaX64 FFX_ISOLATE_DIR=/b/s/w/ir/x/t/VMFRGL ./build/fuchsia/with_envs.py ./third_party/fuchsia/test_scripts/test/run_executable_test.py --test-name=fuchsia-pkg://fuchsia.com/dart_test_release#meta/dart_test_component.cm --test-realm=/core/testing/system-tests --out-dir=out/ReleaseFuchsiaX64/gen/dart_test_release --package-deps=dart_test_release.far --deterministic --enable-vm-service=0 --profiler --disable-dart-dev --sound-null-safety -Dtest_runner.configuration=vm-fuchsia-release-x64 --ignore-unrecognized-flags --packages=pkg/data/.dart_tool/package_config.json --disable-dart-dev pkg/data/tests/ffi/regress_47594_test.dart

exit code:
1

stdout:
Running test 'fuchsia-pkg://fuchsia.com/dart_test_release#meta/dart_test_component.cm'
[RUNNING]	main
[stderr - main]
Could not start the VM service HTTP server:
SocketException: Failed host lookup: 'localhost' (OS Error: System error, errno = -11)
#0      _NativeSocket.lookup.<anonymous closure> (dart:io-patch/socket_patch.dart:595:9)
<asynchronous suspension>
#1      Server.startup.startServer (dart:vmservice_io/vmservice_server.dart:316:25)
<asynchronous suspension>
#2      Server.startup (dart:vmservice_io/vmservice_server.dart:342:5)
<asynchronous suspension>
#3      _toggleWebServer (dart:vmservice_io:251:7)
<asynchronous suspension>
#4      main.<anonymous closure> (dart:vmservice_io:329:31)
<asynchronous suspension>

[FAILED]	main
[00285.141537][1136][1252][<root>] WARN: protocol `fuchsia.net.name.Lookup` was not available for target `core/testing/system-tests:auto-5ee4618e929eb944/test_wrapper/test:test_root`:
	`fuchsia.net.name.Lookup` was not offered to `core/testing/system-tests:auto-5ee4618e929eb944/test_wrapper/test:test_root` by parent
	For more, run `ffx component doctor core/testing/system-tests:auto-5ee4618e929eb944/test_wrapper/test:test_root`

Failed tests: main
0 out of 1 tests passed...
fuchsia-pkg://fuchsia.com/dart_test_release#meta/dart_test_component.cm completed with result: FAILED
Tests failed.

stderr:
WARNING:root:Process exited with status code 1.

--- Re-run this test:
python3 tools/test.py -n vm-fuchsia-release-x64 ffi/regress_47594_test

https://dart-ci.appspot.com/log/vm-fuchsia-release-x64/vm-fuchsia-release-x64/10647/ffi/regress_47594_test

/cc @derekxu16

[derekxu16]

I think this test just needs the profiler to be enabled and not the VM Service, so one way to address this failure is by deleting --enable-vm-service=0 from the test. If that makes sense, here's a CL making that deletion, @dcharkes: https://dart-review.googlesource.com/c/sdk/+/421380.