TSAN failures on macOS ReleaseARM64 bots over the past few days #61445
Description
There are new test failures on Tidy up PluginIsolate fields...[front_end] Enable lint depend_on_referenced_packages.
The tests
corelib/bigint_test/25/5 Crash (expected Pass)
corelib/unsigned_shift_test/01 Crash (expected CompileTimeError)
ffi/isolate_group_bound_init_test/5 Crash (expected Pass)
language/class/literal_static_test/15 Crash (expected CompileTimeError)
language/class/literal_test/19 Crash (expected CompileTimeError)
language/class/literal_test/24 Crash (expected CompileTimeError)
language/const/error_multiply_initialized_test/03 Crash (expected CompileTimeError)
language/control_flow_collections/if_const_error_test/16 Crash (expected CompileTimeError)
language/field/override3_test/00 Crash (expected CompileTimeError)
language/function/syntax_test/65 Crash (expected CompileTimeError)
language/list/literal_syntax_test/05 Crash (expected CompileTimeError)
language/mixin_legacy/factory_constructor_test Crash (expected Pass)
language/nnbd/static_errors/this_reference_in_late_field_test/00 Crash (expected CompileTimeError)
language/nnbd/static_errors/unchecked_use_of_nullable_test/63 Crash (expected CompileTimeError)
language/operator/div_with_power_of_two2_test Crash (expected Pass)
language/operator/modulo_test Crash (expected Pass)
language/set_literals/invalid_set_literal_test/14 Crash (expected CompileTimeError)
language/vm/type_vm_test/26 Crash (expected CompileTimeError)
lib/mirrors/typedef_in_signature_test RuntimeError (expected Pass)
standalone/io/file_system_watcher_test Crash (expected Pass)
standalone/io/http_outgoing_size_test/2 Crash (expected Pass)
standalone/io/http_read_test/1 Crash (expected Pass)
standalone/io/many_file_operations_test Crash (expected Pass)
standalone/io/many_pending_secure_sockets_test Crash (expected Pass)
standalone/io/process_working_directory_test RuntimeError (expected Pass)
standalone/io/web_socket_pipe_test/0 Crash (expected Pass)
vm/cc/IsolateReload_PendingUnqualifiedCall_InstanceToStatic Fail (expected Pass)
vm/dart/awaiter_stacks/flutter_regress_100441_test/1 Crash (expected Pass)
vm/dart/gc/splay_c_finalizer_test/0 Crash (expected Pass)
vm/dart/gc/splay_c_finalizer_test/10 Crash (expected Pass)
and 8 more tests
corelib/regexp/unicode-regexp-zero-length_test Crash (expected Pass)
ffi/function_structs_by_value_generated_args_native_leaf_test/3 Crash (expected Pass)
ffi/vmspecific_leaf_call_test Crash (expected Pass)
language/async/await_test/03/1 Crash (expected Pass)
language/call/method_as_cast_test/01 Crash (expected Pass)
language/call/nonexistent_static_test/03 Crash (expected CompileTimeError)
language/class/literal_static_test/12 Crash (expected CompileTimeError)
language/class/literal_static_test/14 Crash (expected CompileTimeError)
language/class/literal_static_test/16 Crash (expected CompileTimeError)
language/class/literal_static_test/18 Crash (expected CompileTimeError)
language/class/literal_test/06 Crash (expected CompileTimeError)
language/class/literal_test/23 Crash (expected CompileTimeError)
language/class_modifiers/final/final_class_final_subtype_test Crash (expected Pass)
language/class_modifiers/mixin/mixin_class_no_modifier_old_version_test Crash (expected Pass)
language/const/locals_test Crash (expected Pass)
language/control_flow_collections/if_const_error_test/41 Crash (expected CompileTimeError)
language/control_flow_collections/map_set_ambiguity_error_test/01 Crash (expected CompileTimeError)
language/control_flow_collections/map_set_ambiguity_error_test/03 Crash (expected CompileTimeError)
language/control_flow_collections/map_set_ambiguity_error_test/07 Crash (expected CompileTimeError)
language/control_flow_collections/map_set_ambiguity_error_test/12 Crash (expected CompileTimeError)
language/covariant/covariant_test/04 Crash (expected CompileTimeError)
language/covariant/covariant_test/24 Crash (expected CompileTimeError)
language/covariant/covariant_test/27b Crash (expected CompileTimeError)
language/deferred/constraints_type_annotation_test/type_annotation_generic3 Crash (expected CompileTimeError)
language/double_literals/double_literal_coercion_error_test/277 Crash (expected CompileTimeError)
language/exception/try_catch_on_syntax_test/03 Crash (expected CompileTimeError)
language/exception/try_catch_on_syntax_test/10 Crash (expected CompileTimeError)
language/extension_type/exhaustiveness_test Crash (expected Pass)
language/factory/redirection_test/06 Crash (expected CompileTimeError)
language/field/override_test/01 Crash (expected CompileTimeError)
and 90 more tests
are failing on configurations
vm-aot-tsan-mac-release-arm64
vm-tsan-mac-release-arm64
/cc @rmacnak-google as I assume this is related to your recent TSAN work, but these failures have been slowly trickling in over the past few days.
Logs from one example failure:
WARNING: ThreadSanitizer: data race (pid=15614)
Write of size 8 at 0x000121200000 by thread T7 (mutexes: write M0):
#0 dart::Page::Allocate(long, unsigned long) <null> (dartvm:arm64+0x1005a8130)
#1 dart::Scavenger::TryAllocateNewTLAB(dart::Thread*, long, bool) <null> (dartvm:arm64+0x1005bbc64)
#2 dart::Heap::AllocateNew(dart::Thread*, long) <null> (dartvm:arm64+0x100598054)
#3 dart::Heap::Allocate(dart::Thread*, long, dart::Heap::Space) <null> (dartvm:arm64+0x1003f3f68)
#4 dart::Object::Allocate(long, long, dart::Heap::Space, bool, unsigned long, unsigned long) <null> (dartvm:arm64+0x1004144f4)
#5 dart::Instance::NewAlreadyFinalized(dart::Class const&, dart::Heap::Space) <null> (dartvm:arm64+0x10046a8f8)
#6 DRT_AllocateObject <null> (dartvm:arm64+0x1005023a0)
#7 <null> <null> (0x00010a00352c)
#8 dart::DartLibraryCalls::HandleMessage(long long, dart::Instance const&) <null> (dartvm:arm64+0x10035f678)
#9 dart::IsolateMessageHandler::HandleMessage(std::_d::unique_ptr<dart::Message, std::_d::default_delete<dart::Message>>) <null> (dartvm:arm64+0x10039775c)
#10 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool) <null> (dartvm:arm64+0x1003d6528)
#11 dart::MessageHandler::TaskCallback() <null> (dartvm:arm64+0x1003d6b5c)
#12 dart::MessageHandlerTask::Run() <null> (dartvm:arm64+0x1003d7120)
#13 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) <null> (dartvm:arm64+0x100560be0)
#14 dart::ThreadPool::Worker::Main(unsigned long) <null> (dartvm:arm64+0x100561004)
#15 dart::ThreadStart(void*) <null> (dartvm:arm64+0x1004d8af4)
Previous read of size 8 at 0x000121200000 by thread T5:
#0 dart::Zone::~Zone() <null> (dartvm:arm64+0x10057a830)
#1 dart::StackZone::~StackZone() <null> (dartvm:arm64+0x10057aff8)
#2 dart::CompileFunctionHelper(dart::Function const&, bool, long) <null> (dartvm:arm64+0x10057e6e4)
#3 dart::compiler::BailoutWithBranchOffsetError() <null> (dartvm:arm64+0x1005816b4)
#4 dart::compiler::Assembler::BindImm14Branch(long long, long long) <null> (dartvm:arm64+0x10061911c)
#5 dart::compiler::Assembler::Bind(dart::compiler::Label*) <null> (dartvm:arm64+0x1006199c8)
#6 dart::CompilerDeoptInfoWithStub::GenerateCode(dart::FlowGraphCompiler*, long) <null> (dartvm:arm64+0x10066104c)
#7 dart::FlowGraphCompiler::GenerateDeferredCode() <null> (dartvm:arm64+0x100655780)
#8 dart::FlowGraphCompiler::CompileGraph() <null> (dartvm:arm64+0x1006546b4)
#9 dart::CompilerPass_GenerateCode::DoBody(dart::CompilerPassState*) const <null> (dartvm:arm64+0x100783fec)
#10 dart::CompilerPass::Run(dart::CompilerPassState*) const <null> (dartvm:arm64+0x100781b48)
#11 dart::CompileParsedFunctionHelper::Compile() <null> (dartvm:arm64+0x10057d688)
#12 dart::CompileFunctionHelper(dart::Function const&, bool, long) <null> (dartvm:arm64+0x10057e130)
#13 dart::Compiler::CompileOptimizedFunction(dart::Thread*, dart::Function const&, long) <null> (dartvm:arm64+0x10057eb20)
#14 dart::BackgroundCompiler::Run() <null> (dartvm:arm64+0x10057f67c)
#15 dart::BackgroundCompilerTask::Run() <null> (dartvm:arm64+0x1005804cc)
#16 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) <null> (dartvm:arm64+0x100560be0)
#17 dart::ThreadPool::Worker::Main(unsigned long) <null> (dartvm:arm64+0x100561004)
#18 dart::ThreadStart(void*) <null> (dartvm:arm64+0x1004d8af4)
Mutex M0 (0x000109b0f790) created at:
#0 pthread_mutex_init <null> (libclang_rt.tsan_osx_dynamic.dylib:arm64+0x324e0)
#1 dart::Mutex::Mutex() <null> (dartvm:arm64+0x10000c054)
#2 dart::Mutex::Mutex() <null> (dartvm:arm64+0x10000c1e4)
#3 dart::Scavenger::Scavenger(dart::Heap*, long) <null> (dartvm:arm64+0x1005b67f8)
#4 dart::Scavenger::Scavenger(dart::Heap*, long) <null> (dartvm:arm64+0x1005b69dc)
#5 dart::Heap::Heap(dart::IsolateGroup*, bool, long, long) <null> (dartvm:arm64+0x100597818)
#6 dart::Heap::Init(dart::IsolateGroup*, bool, long, long) <null> (dartvm:arm64+0x10059b514)
#7 dart::IsolateGroup::CreateHeap(bool, bool) <null> (dartvm:arm64+0x100390818)
#8 Dart_CreateIsolateGroup <null> (dartvm:arm64+0x1008affc0)
#9 dart::bin::CreateIsolateGroupAndSetup(char const*, char const*, char const*, char const*, Dart_IsolateFlags*, void*, char**) <null> (dartvm:arm64+0x100005d64)
#10 dart::RunKernelTask::Run() <null> (dartvm:arm64+0x1003c58c8)
#11 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) <null> (dartvm:arm64+0x100560be0)
#12 dart::ThreadPool::Worker::Main(unsigned long) <null> (dartvm:arm64+0x100561004)
#13 dart::ThreadStart(void*) <null> (dartvm:arm64+0x1004d8af4)
Thread T7 (tid=174052, running) created by thread T5 at:
#0 pthread_create <null> (libclang_rt.tsan_osx_dynamic.dylib:arm64+0x30b68)
#1 dart::OSThread::TryStart(char const*, void (*)(unsigned long), unsigned long) <null> (dartvm:arm64+0x1004d89b4)
#2 dart::OSThread::Start(char const*, void (*)(unsigned long), unsigned long) <null> (dartvm:arm64+0x1004d87f0)
#3 dart::ThreadPool::RunImpl(std::_d::unique_ptr<dart::ThreadPool::Task, std::_d::default_delete<dart::ThreadPool::Task>>) <null> (dartvm:arm64+0x100560494)
#4 dart::MessageHandler::Run(dart::ThreadPool*, dart::MessageHandler::MessageStatus (*)(unsigned long), void (*)(unsigned long), unsigned long) <null> (dartvm:arm64+0x1003d5fe8)
#5 dart::RunKernelTask::Run() <null> (dartvm:arm64+0x1003c5aa8)
#6 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) <null> (dartvm:arm64+0x100560be0)
#7 dart::ThreadPool::Worker::Main(unsigned long) <null> (dartvm:arm64+0x100561004)
#8 dart::ThreadStart(void*) <null> (dartvm:arm64+0x1004d8af4)
Thread T5 (tid=174048, running) created by main thread at:
#0 pthread_create <null> (libclang_rt.tsan_osx_dynamic.dylib:arm64+0x30b68)
#1 dart::OSThread::TryStart(char const*, void (*)(unsigned long), unsigned long) <null> (dartvm:arm64+0x1004d89b4)
#2 dart::OSThread::Start(char const*, void (*)(unsigned long), unsigned long) <null> (dartvm:arm64+0x1004d87f0)
#3 dart::ThreadPool::RunImpl(std::_d::unique_ptr<dart::ThreadPool::Task, std::_d::default_delete<dart::ThreadPool::Task>>) <null> (dartvm:arm64+0x100560494)
#4 dart::KernelIsolate::Start() <null> (dartvm:arm64+0x1003c1f9c)
#5 dart::KernelIsolate::CompileToKernel(char const*, unsigned char const*, long, int, Dart_SourceFile*, bool, bool, bool, char const*, char const*, char const*, Dart_KernelCompilationVerbosityLevel) <null> (dartvm:arm64+0x1003c2480)
#6 Dart_CompileToKernel <null> (dartvm:arm64+0x1008df0d0)
#7 dart::bin::DFE::CompileAndReadScript(char const*, unsigned char**, long*, char**, int*, char const*, bool, bool) <null> (dartvm:arm64+0x1000030ec)
#8 dart::bin::IsolateSetupHelper(_Dart_Isolate*, bool, char const*, char const*, bool, Dart_IsolateFlags*, char**, int*) <null> (dartvm:arm64+0x100006a38)
#9 dart::bin::CreateIsolateGroupAndSetupHelper(bool, char const*, char const*, char const*, char const*, Dart_IsolateFlags*, void*, char**, int*) <null> (dartvm:arm64+0x100004898)
#10 dart::bin::RunMainIsolate(char const*, char const*, char const*, dart::bin::CommandLineOptions*) <null> (dartvm:arm64+0x1000041e0)
#11 dart::bin::main(int, char**) <null> (dartvm:arm64+0x100005558)
#12 main <null> (dartvm:arm64+0x100004084)
SUMMARY: ThreadSanitizer: data race (/Volumes/Work/s/w/ir/xcodebuild/ReleaseTSANARM64/dartvm:arm64+0x1005a8130) in dart::Page::Allocate(long, unsigned long)
==================
--- Re-run this test:
python3 tools/test.py -n vm-tsan-mac-release-arm64 language/closure/partial_tearoff_instantiation_test/05